From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eimNf-0001ta-0i for qemu-devel@nongnu.org; Mon, 05 Feb 2018 14:24:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eimNd-0002pQ-VU for qemu-devel@nongnu.org; Mon, 05 Feb 2018 14:24:43 -0500 References: <20180205162745.23650-1-mreitz@redhat.com> From: Eric Blake Message-ID: <73421d5f-c40b-bc7d-6da4-6c129db53696@redhat.com> Date: Mon, 5 Feb 2018 13:24:33 -0600 MIME-Version: 1.0 In-Reply-To: <20180205162745.23650-1-mreitz@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-img: Make resize error message more general List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org On 02/05/2018 10:27 AM, Max Reitz wrote: > The issue: > > $ qemu-img resize -f qcow2 foo.qcow2 > qemu-img: Expecting one image file name > Try 'qemu-img --help' for more information > > So we gave an image file name, but we omitted the length. qemu-img > thinks the last argument is always the size and removes it immediately > from argv (by decrementing argc), and tries to verify that it is a valid > size only at a later point. > > So we do not actually know whether that last argument we called "size" > is indeed a size or whether the user instead forgot to specify that size > but did give a file name. > > Therefore, the error message should be more general. > > Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1523458 > Signed-off-by: Max Reitz > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 68b375f998..2753b63514 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -3468,7 +3468,7 @@ static int img_resize(int argc, char **argv) > } > } > if (optind != argc - 1) { > - error_exit("Expecting one image file name"); > + error_exit("Expecting image file name and size"); Yes, that reads better in the context you described. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org