From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
qemu-trivial@nongnu.org, Ani Sinha <ani@anisinha.ca>,
Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 4/4] hw/i386/acpi-build: Generate AML for north and south bridges separately
Date: Thu, 27 Oct 2022 23:56:32 +0200 [thread overview]
Message-ID: <736a625c-11ce-dea4-2404-dccaaba27800@linaro.org> (raw)
In-Reply-To: <20221026133110.91828-5-shentey@gmail.com>
On 26/10/22 15:31, Bernhard Beschow wrote:
> The code currently assumes Q35 iff ICH9 and i440fx iff PIIX. This is
> slightly confusing when trying to understand the code. Split north and
> south bridge code to communicate which piece of code assumes which type
> of bridge.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> hw/i386/acpi-build.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2022-10-27 21:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 13:31 [PATCH 0/4] Cleanup AML generation for north and south bridges Bernhard Beschow
2022-10-26 13:31 ` [PATCH 1/4] hw/i386/acpi-build: Remove unused struct Bernhard Beschow
2022-10-26 15:27 ` Philippe Mathieu-Daudé
2022-10-26 13:31 ` [PATCH 2/4] hw/i386/acpi-build: Resolve redundant attribute Bernhard Beschow
2022-10-27 21:53 ` Philippe Mathieu-Daudé
2022-10-26 13:31 ` [PATCH 3/4] hw/i386/acpi-build: Resolve PIIX ISA bridge rather than ACPI controller Bernhard Beschow
2022-10-27 21:56 ` Philippe Mathieu-Daudé
2022-10-26 13:31 ` [PATCH 4/4] hw/i386/acpi-build: Generate AML for north and south bridges separately Bernhard Beschow
2022-10-27 21:56 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=736a625c-11ce-dea4-2404-dccaaba27800@linaro.org \
--to=philmd@linaro.org \
--cc=ani@anisinha.ca \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).