From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "John Snow" <jsnow@redhat.com>
Subject: Re: [PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC
Date: Thu, 20 May 2021 09:16:14 +0200 [thread overview]
Message-ID: <736efc80-3f55-80e7-9f15-f4a6c619c7d1@redhat.com> (raw)
In-Reply-To: <1888fae1-5546-490c-b564-68be17904fca@redhat.com>
On 19/05/2021 13.05, Philippe Mathieu-Daudé wrote:
> On 5/19/21 10:23 AM, Thomas Huth wrote:
>> On 18/05/2021 21.32, Philippe Mathieu-Daudé wrote:
>>> isa_superio_realize() calls isa_fdc_init_drives(), which is defined
>>> in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol.
>>
>> If I get that right, not all superio chipsets provide a floppy drive
>> (there's this "k->floppy.is_enabled" check in there) ... but for boards
>> that don't need the FDC, this would currently require a stub for that
>> function
>
> Good point. I'll try to get it right.
As discussed in v6, all superio chips currently have a way to use an FDC, so
this version of the patch is fine:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-05-20 7:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 19:32 [PATCH v5 0/6] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers Philippe Mathieu-Daudé
2021-05-18 19:32 ` [PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC Philippe Mathieu-Daudé
2021-05-19 8:23 ` Thomas Huth
2021-05-19 11:05 ` Philippe Mathieu-Daudé
2021-05-20 7:16 ` Thomas Huth [this message]
2021-05-18 19:32 ` [PATCH v5 2/6] hw/block/fdc: Replace disabled fprintf() by trace event Philippe Mathieu-Daudé
2021-05-18 19:32 ` [PATCH v5 3/6] hw/block/fdc: Declare shared prototypes in fdc-internal.h Philippe Mathieu-Daudé
2021-05-18 19:32 ` [PATCH v5 4/6] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c Philippe Mathieu-Daudé
2021-05-18 19:32 ` [PATCH v5 5/6] hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c Philippe Mathieu-Daudé
2021-05-18 19:32 ` [PATCH v5 6/6] hw/block/fdc: Add sysbus_fdc_init_drives() method Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=736efc80-3f55-80e7-9f15-f4a6c619c7d1@redhat.com \
--to=thuth@redhat.com \
--cc=jsnow@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).