From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v5 6/7] meson: add spice dependency to core spice source files.
Date: Wed, 14 Oct 2020 15:39:08 +0200 [thread overview]
Message-ID: <7377acf7-b6a8-a037-54c0-ec66cc1f0f1e@redhat.com> (raw)
In-Reply-To: <20201014121120.13482-7-kraxel@redhat.com>
On 10/14/20 2:11 PM, Gerd Hoffmann wrote:
> Right now it happens to work by pure luck because the spice chardevs
> add the spice dependency to the softmmu source set. That'll change
> though once we start building spice chardevs as module, so lets fix
> it properly.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ui/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-10-14 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 12:11 [PATCH v5 0/7] build spice chardevs as module Gerd Hoffmann
2020-10-14 12:11 ` [PATCH v5 1/7] qemu-edid: drop cast Gerd Hoffmann
2020-10-14 12:11 ` [PATCH v5 2/7] ui/spice-app: don't use qemu_chr_open_spice_port directly Gerd Hoffmann
2020-10-14 12:11 ` [PATCH v5 3/7] chardev/spice: make qemu_chr_open_spice_port static Gerd Hoffmann
2020-10-14 12:11 ` [PATCH v5 4/7] chardev/spice: simplify chardev setup Gerd Hoffmann
2020-10-14 12:11 ` [PATCH v5 5/7] meson: add spice_headers dependency Gerd Hoffmann
2020-10-14 12:11 ` [PATCH v5 6/7] meson: add spice dependency to core spice source files Gerd Hoffmann
2020-10-14 13:39 ` Philippe Mathieu-Daudé [this message]
2020-10-14 12:11 ` [PATCH v5 7/7] chardev/spice: build spice chardevs as module Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7377acf7-b6a8-a037-54c0-ec66cc1f0f1e@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).