From: Paolo Bonzini <pbonzini@redhat.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress
Date: Tue, 2 Apr 2019 12:20:38 +0200 [thread overview]
Message-ID: <73925ca6-37ee-f932-ceb5-3144cd6b05cc@redhat.com> (raw)
In-Reply-To: <47EDAADB-151A-43DC-B137-6E6DCD11BB64@oracle.com>
On 02/04/19 11:08, Liran Alon wrote:
>> -
>> - if (((entry >> IOAPIC_LVT_TRIGGER_MODE_SHIFT) & 1) !=
>> - IOAPIC_TRIGGER_LEVEL) {
>> + if (!(entry & IOAPIC_LVT_REMOTE_IRR)) {
>> continue;
>> }
> I think above “if” of checking remote-irr should just be removed.
> But the rest seems good :)
>
It seems more logical, as the condition is now the opposite of
ioapic_set_irq: ioapic_set_irq services the interrupt if remote-irr = 0,
EOI does it if remote-irr = 1.
Paolo
next prev parent reply other threads:[~2019-04-02 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 8:02 [Qemu-devel] [PATCH v2] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress Vitaly Kuznetsov
2019-04-02 8:23 ` Liran Alon
2019-04-02 9:06 ` Paolo Bonzini
2019-04-02 9:08 ` Liran Alon
2019-04-02 10:20 ` Paolo Bonzini [this message]
2019-04-02 11:36 ` Liran Alon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73925ca6-37ee-f932-ceb5-3144cd6b05cc@redhat.com \
--to=pbonzini@redhat.com \
--cc=liran.alon@oracle.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).