qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ishani <chugh.ishani@research.iiit.ac.in>
To: stefanha <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, jsnow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6] Add manpage for QEMU Backup Tool
Date: Fri, 21 Jul 2017 02:28:54 +0530 (IST)	[thread overview]
Message-ID: <739348374.292427.1500584334946.JavaMail.zimbra@research.iiit.ac.in> (raw)
In-Reply-To: <20170720124618.GD32383@stefanha-x1.localdomain>


----- On Jul 20, 2017, at 6:16 PM, stefanha stefanha@redhat.com wrote:

> On Tue, Jul 18, 2017 at 12:45:36AM +0530, Ishani Chugh wrote:
> 
> This looks good.  I think it makes sense to include this patch with the
> patch series that adds the qemu-backup command.  That way the command
> and its man page will be merged together.

Thanks. I will include the patch for qemu-backup in same patch series.
 
>> +@item qemu-backup guest add --guest guestname --qmp socketpath [--tcp]
> 
> For consistency I suggest following QEMU chardev syntax for the socket
> path.  This also allows you to drop --tcp.
> 
> UNIX domain sockets look like this:
> 
>  unix:/path/to/socket
> 
> TCP addresses look like this:
> 
>   tcp:127.0.0.1:1234
Okay. Will fix it in next revision.Thanks.

      reply	other threads:[~2017-07-20 20:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 19:15 [Qemu-devel] [PATCH v6] Add manpage for QEMU Backup Tool Ishani Chugh
2017-07-20 12:46 ` Stefan Hajnoczi
2017-07-20 20:58   ` Ishani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=739348374.292427.1500584334946.JavaMail.zimbra@research.iiit.ac.in \
    --to=chugh.ishani@research.iiit.ac.in \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).