From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Wen Congyang <wencongyang2@huawei.com>,
Xie Changlong <xiechanglong.d@gmail.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH] replication: move include out of root directory
Date: Mon, 17 May 2021 15:33:40 +0200 [thread overview]
Message-ID: <73a1d9f2-f2e9-128f-c871-c419d74daca9@redhat.com> (raw)
In-Reply-To: <20210517121909.2625099-1-pbonzini@redhat.com>
On 5/17/21 2:19 PM, Paolo Bonzini wrote:
> The replication.h file is included from migration/colo.c and tests/unit/test-replication.c,
> so it should be in include/.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/replication.c | 2 +-
> replication.h => include/block/replication.h | 4 ++--
> migration/colo.c | 2 +-
> replication.c | 2 +-
> tests/unit/test-replication.c | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
> rename replication.h => include/block/replication.h (98%)
Including the following hunk:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
-- >8 --
diff --git a/MAINTAINERS b/MAINTAINERS
index 7877710e372..34c60d9284f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3257,8 +3257,9 @@ Replication
M: Wen Congyang <wencongyang2@huawei.com>
M: Xie Changlong <xiechanglong.d@gmail.com>
S: Supported
-F: replication*
+F: replication.c
F: block/replication.c
+F: include/block/replication.h
F: tests/unit/test-replication.c
F: docs/block-replication.txt
---
prev parent reply other threads:[~2021-05-17 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 12:19 [PATCH] replication: move include out of root directory Paolo Bonzini
2021-05-17 13:33 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a1d9f2-f2e9-128f-c871-c419d74daca9@redhat.com \
--to=philmd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).