* [PATCH] virtio-rng: block max-bytes=0
@ 2024-07-24 10:51 Michael S. Tsirkin
2024-07-24 11:06 ` Laurent Vivier
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2024-07-24 10:51 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier, Amit Shah
with max-bytes set to 0, quota is 0 and so device does not work.
block this to avoid user confusion
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/virtio-rng.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index f74efffef7..7cf31da071 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -184,8 +184,9 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp)
/* Workaround: Property parsing does not enforce unsigned integers,
* So this is a hack to reject such numbers. */
- if (vrng->conf.max_bytes > INT64_MAX) {
- error_setg(errp, "'max-bytes' parameter must be non-negative, "
+ if (vrng->conf.max_bytes == 0 ||
+ vrng->conf.max_bytes > INT64_MAX) {
+ error_setg(errp, "'max-bytes' parameter must be positive, "
"and less than 2^63");
return;
}
--
MST
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-rng: block max-bytes=0
2024-07-24 10:51 [PATCH] virtio-rng: block max-bytes=0 Michael S. Tsirkin
@ 2024-07-24 11:06 ` Laurent Vivier
2024-07-24 12:30 ` Amit Shah
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2024-07-24 11:06 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Amit Shah
On 24/07/2024 12:51, Michael S. Tsirkin wrote:
> with max-bytes set to 0, quota is 0 and so device does not work.
> block this to avoid user confusion
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/virtio/virtio-rng.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
> index f74efffef7..7cf31da071 100644
> --- a/hw/virtio/virtio-rng.c
> +++ b/hw/virtio/virtio-rng.c
> @@ -184,8 +184,9 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp)
>
> /* Workaround: Property parsing does not enforce unsigned integers,
> * So this is a hack to reject such numbers. */
> - if (vrng->conf.max_bytes > INT64_MAX) {
> - error_setg(errp, "'max-bytes' parameter must be non-negative, "
> + if (vrng->conf.max_bytes == 0 ||
> + vrng->conf.max_bytes > INT64_MAX) {
> + error_setg(errp, "'max-bytes' parameter must be positive, "
> "and less than 2^63");
> return;
> }
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-rng: block max-bytes=0
2024-07-24 10:51 [PATCH] virtio-rng: block max-bytes=0 Michael S. Tsirkin
2024-07-24 11:06 ` Laurent Vivier
@ 2024-07-24 12:30 ` Amit Shah
2024-07-25 7:05 ` Philippe Mathieu-Daudé
2024-07-30 9:07 ` Laurent Vivier
3 siblings, 0 replies; 6+ messages in thread
From: Amit Shah @ 2024-07-24 12:30 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Laurent Vivier
On Wed, 2024-07-24 at 06:51 -0400, Michael S. Tsirkin wrote:
> with max-bytes set to 0, quota is 0 and so device does not work.
> block this to avoid user confusion
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/virtio/virtio-rng.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
> index f74efffef7..7cf31da071 100644
> --- a/hw/virtio/virtio-rng.c
> +++ b/hw/virtio/virtio-rng.c
> @@ -184,8 +184,9 @@ static void virtio_rng_device_realize(DeviceState
> *dev, Error **errp)
>
> /* Workaround: Property parsing does not enforce unsigned
> integers,
> * So this is a hack to reject such numbers. */
> - if (vrng->conf.max_bytes > INT64_MAX) {
> - error_setg(errp, "'max-bytes' parameter must be non-
> negative, "
> + if (vrng->conf.max_bytes == 0 ||
> + vrng->conf.max_bytes > INT64_MAX) {
> + error_setg(errp, "'max-bytes' parameter must be positive, "
> "and less than 2^63");
> return;
> }
Reviewed-by: Amit Shah <amit@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-rng: block max-bytes=0
2024-07-24 10:51 [PATCH] virtio-rng: block max-bytes=0 Michael S. Tsirkin
2024-07-24 11:06 ` Laurent Vivier
2024-07-24 12:30 ` Amit Shah
@ 2024-07-25 7:05 ` Philippe Mathieu-Daudé
2024-07-30 9:07 ` Laurent Vivier
3 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-07-25 7:05 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Laurent Vivier, Amit Shah
On 24/7/24 12:51, Michael S. Tsirkin wrote:
> with max-bytes set to 0, quota is 0 and so device does not work.
> block this to avoid user confusion
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/virtio/virtio-rng.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-rng: block max-bytes=0
2024-07-24 10:51 [PATCH] virtio-rng: block max-bytes=0 Michael S. Tsirkin
` (2 preceding siblings ...)
2024-07-25 7:05 ` Philippe Mathieu-Daudé
@ 2024-07-30 9:07 ` Laurent Vivier
2024-07-30 11:29 ` Michael S. Tsirkin
3 siblings, 1 reply; 6+ messages in thread
From: Laurent Vivier @ 2024-07-30 9:07 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Amit Shah
On 24/07/2024 12:51, Michael S. Tsirkin wrote:
> with max-bytes set to 0, quota is 0 and so device does not work.
> block this to avoid user confusion
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/virtio/virtio-rng.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
> index f74efffef7..7cf31da071 100644
> --- a/hw/virtio/virtio-rng.c
> +++ b/hw/virtio/virtio-rng.c
> @@ -184,8 +184,9 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp)
>
> /* Workaround: Property parsing does not enforce unsigned integers,
> * So this is a hack to reject such numbers. */
> - if (vrng->conf.max_bytes > INT64_MAX) {
> - error_setg(errp, "'max-bytes' parameter must be non-negative, "
> + if (vrng->conf.max_bytes == 0 ||
> + vrng->conf.max_bytes > INT64_MAX) {
> + error_setg(errp, "'max-bytes' parameter must be positive, "
> "and less than 2^63");
> return;
> }
Michael, do you plan to send the PR yourself? Or perhaps it can go via trivial?
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-rng: block max-bytes=0
2024-07-30 9:07 ` Laurent Vivier
@ 2024-07-30 11:29 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2024-07-30 11:29 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-devel, Amit Shah
On Tue, Jul 30, 2024 at 11:07:11AM +0200, Laurent Vivier wrote:
> On 24/07/2024 12:51, Michael S. Tsirkin wrote:
> > with max-bytes set to 0, quota is 0 and so device does not work.
> > block this to avoid user confusion
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > hw/virtio/virtio-rng.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
> > index f74efffef7..7cf31da071 100644
> > --- a/hw/virtio/virtio-rng.c
> > +++ b/hw/virtio/virtio-rng.c
> > @@ -184,8 +184,9 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp)
> > /* Workaround: Property parsing does not enforce unsigned integers,
> > * So this is a hack to reject such numbers. */
> > - if (vrng->conf.max_bytes > INT64_MAX) {
> > - error_setg(errp, "'max-bytes' parameter must be non-negative, "
> > + if (vrng->conf.max_bytes == 0 ||
> > + vrng->conf.max_bytes > INT64_MAX) {
> > + error_setg(errp, "'max-bytes' parameter must be positive, "
> > "and less than 2^63");
> > return;
> > }
>
> Michael, do you plan to send the PR yourself? Or perhaps it can go via trivial?
>
> Thanks,
> Laurent
I will pick it up, I do not think this is appropriate for trivial though.
--
MST
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-07-30 11:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-24 10:51 [PATCH] virtio-rng: block max-bytes=0 Michael S. Tsirkin
2024-07-24 11:06 ` Laurent Vivier
2024-07-24 12:30 ` Amit Shah
2024-07-25 7:05 ` Philippe Mathieu-Daudé
2024-07-30 9:07 ` Laurent Vivier
2024-07-30 11:29 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).