From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0AEEC7619A for ; Sat, 8 Apr 2023 04:30:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pl0DI-0004Hg-9F; Sat, 08 Apr 2023 00:30:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl0DG-0004Gz-Dp for qemu-devel@nongnu.org; Sat, 08 Apr 2023 00:30:06 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pl0DE-0007Dh-14 for qemu-devel@nongnu.org; Sat, 08 Apr 2023 00:30:06 -0400 Received: by mail-pj1-x102d.google.com with SMTP id bp17-20020a17090b0c1100b0023f187954acso306593pjb.2 for ; Fri, 07 Apr 2023 21:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680928202; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wQs4SC5lYlKd/34OSFcaA0sSEu14qWxU3jsCupypxlU=; b=kUaGPTveG0lxEI28vTpDb9Jw7OfLi4TPDm7kQSZcLfBmpgcZpWdfC+nC/VxxkU8g0D uhY6ay8Ow6fqnxgPs2ScCkFW1hcpY7bHeEG4IdUb84QinAnoHlZ/bD+jiGDDXNMAb7wl Npca4GkUEsp31W/9wZ0nnBKCzHIqzQFY5qH9Qc0eEflC/0q10hpGTG2fpyWmuFAX5HvI oK64dK+t86fzN0Fs16v9ZDiZm2LWdeyflbaMdQKGIXyrAgXu103KIOcVnM9mWpipo5OX Nh6sD6s0cr0WvBlYzRNzJAi8pxf7y2zmuhnUcQx+8qbwYEnNCaHWH/aUzB2Bef22N40d KNIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680928202; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wQs4SC5lYlKd/34OSFcaA0sSEu14qWxU3jsCupypxlU=; b=XEYHqJ4umyGgMPkTC2JjM6D6IlKxD2gOYbo6wK2vMrocY1a6WN8bNQTVm1/ahfSV+7 vC+jTULL5UB08edVzQHM9/ndo8D+jkIkqVqGJ8ITvyoRLB2AaXG3c1upjLIZNpwGkzHb er7zN4ppV3FDWVExGfpvnc4qVF3vIHc0/QfCCvHV902JtrA9nvyyIcZ7hizJG6erXKun YR5o15B+IEOLw3ntN5yZYdkL87RaBl3Y70uvVuCA88I6is72ZnZmSBS0KdyuZQGRtOqI OmNwSqDFd8a28YQIAT5seBuinq5CedG8srH1Sxpk4+y+9NEN7OV4gHOOgErFEsqw8n+r 7+Bg== X-Gm-Message-State: AAQBX9cnkcIONr7Xv2BPSlO0UL8Uc58O9uA/F8JfUvD3SDJ0JFWVJNrs vguhzkFlQKzi3Foi6A7oovrFDQ== X-Google-Smtp-Source: AKy350bSf+NJer4y36s5JHSJa51+w0WLdRxuVnS+TxQLWRCkIT+ZrofzrzsIKVKZztNYWN9UFvABiw== X-Received: by 2002:a05:6a20:ce1f:b0:d8:bed9:33cf with SMTP id ic31-20020a056a20ce1f00b000d8bed933cfmr4258225pzb.17.1680928202146; Fri, 07 Apr 2023 21:30:02 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id j10-20020a62e90a000000b005a7f8a326a3sm3781655pfh.50.2023.04.07.21.30.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 21:30:01 -0700 (PDT) Message-ID: <73bb88d3-7218-6ecf-2feb-2ad340d5e61c@linaro.org> Date: Fri, 7 Apr 2023 21:29:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC PATCH 09/10] target/riscv: Restrict KVM-specific fields from ArchCPU Content-Language: en-US From: Richard Henderson To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, kvm@vger.kernel.org, qemu-ppc@nongnu.org, Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei References: <20230405160454.97436-1-philmd@linaro.org> <20230405160454.97436-10-philmd@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.03, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/7/23 21:28, Richard Henderson wrote: > On 4/5/23 09:04, Philippe Mathieu-Daudé wrote: >> These fields shouldn't be accessed when KVM is not available. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> RFC: The migration part is likely invalid... >> >> kvmtimer_needed() is defined in target/riscv/machine.c as >> >>    static bool kvmtimer_needed(void *opaque) >>    { >>        return kvm_enabled(); >>    } >> >> which depends on a host feature. >> --- >>   target/riscv/cpu.h     | 2 ++ >>   target/riscv/machine.c | 4 ++++ >>   2 files changed, 6 insertions(+) > > Yeah, the kvm parts need to be extracted to their own subsection. Oh, but they are. Ho hum, it's getting late. r~