From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99A11C48BD7 for ; Tue, 25 Jun 2019 13:55:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FEB72146E for ; Tue, 25 Jun 2019 13:55:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FEB72146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60512 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfluo-0002HB-IT for qemu-devel@archiver.kernel.org; Tue, 25 Jun 2019 09:55:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60144) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hflgU-0007kT-AF for qemu-devel@nongnu.org; Tue, 25 Jun 2019 09:40:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hflgT-0005tV-5Y for qemu-devel@nongnu.org; Tue, 25 Jun 2019 09:40:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51160) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hflgS-0005sU-Rf for qemu-devel@nongnu.org; Tue, 25 Jun 2019 09:40:29 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DDE6D3082E6E; Tue, 25 Jun 2019 13:40:20 +0000 (UTC) Received: from [10.3.116.44] (ovpn-116-44.phx2.redhat.com [10.3.116.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19CAF5C236; Tue, 25 Jun 2019 13:40:15 +0000 (UTC) To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Colin Xu References: <20190625032142.13854-1-colin.xu@intel.com> <20190625104246.GD3139@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <73d2325b-155b-cc74-3475-d01f83d7a7f4@redhat.com> Date: Tue, 25 Jun 2019 08:40:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190625104246.GD3139@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="of0NmFGjnx1w5q16LK6ExEC8Pf0A9UNeH" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 25 Jun 2019 13:40:25 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] ui: Correct icon install path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, "stefanha@redhat.com" , kraxel@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --of0NmFGjnx1w5q16LK6ExEC8Pf0A9UNeH Content-Type: multipart/mixed; boundary="lR9sduvbxwLZGap4STPMOBfRFxZlevuFX"; protected-headers="v1" From: Eric Blake To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Colin Xu Cc: qemu-devel@nongnu.org, kraxel@redhat.com, "stefanha@redhat.com" Message-ID: <73d2325b-155b-cc74-3475-d01f83d7a7f4@redhat.com> Subject: Re: [Qemu-devel] [PATCH] ui: Correct icon install path References: <20190625032142.13854-1-colin.xu@intel.com> <20190625104246.GD3139@redhat.com> In-Reply-To: <20190625104246.GD3139@redhat.com> --lR9sduvbxwLZGap4STPMOBfRFxZlevuFX Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/25/19 5:42 AM, Daniel P. Berrang=C3=A9 wrote: > On Tue, Jun 25, 2019 at 11:21:42AM +0800, Colin Xu wrote: >> The double slash in path will fail the installation on MINGW/MSYS. >> >> Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons) >> >> Signed-off-by: Colin Xu >> --- >> Makefile | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > Hmmm I swear this exact fix has been posted before but I can't find > / remember where and obviously it didnt get merged. https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg04885.html --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --lR9sduvbxwLZGap4STPMOBfRFxZlevuFX-- --of0NmFGjnx1w5q16LK6ExEC8Pf0A9UNeH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl0SJD4ACgkQp6FrSiUn Q2rtOwf9EE+aKkt0R4OCK82rsyth3VdK6AW7TH5H5KiDhszjCE5Ur/WzBUnlF4Yf qWwuFDzhCpdUoB526sTfCgRqSyHFZ/IRZcOsLNDNSGDr8uW0t7hR9nrjnjfkM76c hYf7o8ZIXwJrzH2V99YyEZBpMIYjhWPjDTZWQlaY5JRs2wOVkx5O7IZ70jp8laef 2mup1DzETNNRhSY1NolnCcJkUbzYuPN4khbCJyRz76dHNhuZQ09zhw+X+njI5dEU K7KfhuLmvbamNnFq8kEFNRev02kJtl8UgLa9qPv6PbqTEEADDCCl1kKvp2dhak3h p47O0rgQ4fSibcIodAMO1GvT/5TNoQ== =+wei -----END PGP SIGNATURE----- --of0NmFGjnx1w5q16LK6ExEC8Pf0A9UNeH--