From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>, Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
John Reiser <jreiser@bitwagon.com>,
"Markus F.X.J. Oberhumer" <markus@oberhumer.com>
Subject: Re: [PATCH v3] linux-user/armeb: Fix __kernel_cmpxchg() for armeb
Date: Fri, 28 Jul 2023 13:57:03 -0700 [thread overview]
Message-ID: <73d477e3-a647-a166-f735-3d1400e505b0@linaro.org> (raw)
In-Reply-To: <b3249b9e-d687-68e1-77b6-9c8703644266@linaro.org>
On 7/28/23 13:51, Richard Henderson wrote:
> On 7/28/23 12:23, Helge Deller wrote:
>> + /* endianess-swap if emulating armeb */
>> + oldval = tswap64(oldval);
>> + newval = tswap64(newval);
>
> Oh btw, it's not about arm vs armeb, but guest vs host.
> This also fixes armel on big-endian hosts.
Anyway, I adjusted the comment and queued.
r~
next prev parent reply other threads:[~2023-07-28 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 19:23 [PATCH v3] linux-user/armeb: Fix __kernel_cmpxchg() for armeb Helge Deller
2023-07-28 20:49 ` Richard Henderson
2023-07-28 20:51 ` Richard Henderson
2023-07-28 20:57 ` Richard Henderson [this message]
2023-07-28 21:03 ` Helge Deller
2023-07-31 9:42 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73d477e3-a647-a166-f735-3d1400e505b0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=jreiser@bitwagon.com \
--cc=laurent@vivier.eu \
--cc=markus@oberhumer.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).