From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Anton Volkov <arvolkov@inbox.ru>
Cc: borntraeger@de.ibm.com, agraf@suse.de, qemu-devel@nongnu.org,
kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw: dead code removal
Date: Tue, 21 Mar 2017 12:22:01 +0100 [thread overview]
Message-ID: <73e35c44-eda8-318c-77a3-0a7d42704dba@redhat.com> (raw)
In-Reply-To: <87o9wvrmwa.fsf@dusky.pond.sub.org>
On 21/03/2017 10:37, Markus Armbruster wrote:
> Four related changes, really:
>
> 1. HDACodecDeviceClass method exit()
> 2. VirtIOCCWDeviceClass method exit()
> 3. DeviceClass method exit()
> 4. SCLPEventClass method exit()
>
> Regarding 3: method exit() needs to go. Your patch shows there are only
> a few remaining users. Please convert them to unrealize().
But that should be a separate patch anyway, so this patch should be good
as is, shouldn't it?
Paolo
next prev parent reply other threads:[~2017-03-21 11:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 18:00 [Qemu-devel] [PATCH] hw: dead code removal Anton Volkov
2017-03-21 8:28 ` Cornelia Huck
2017-03-21 8:50 ` Frederic Konrad
2017-03-21 9:37 ` Markus Armbruster
2017-03-21 11:22 ` Paolo Bonzini [this message]
2017-03-21 11:56 ` Markus Armbruster
2017-03-21 12:05 ` Thomas Huth
2017-03-21 12:48 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73e35c44-eda8-318c-77a3-0a7d42704dba@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=arvolkov@inbox.ru \
--cc=borntraeger@de.ibm.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).