From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org, "Emilio G. Cota" <cota@braap.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
"open list:Trivial patches" <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v11 6/6] trace: [trivial] Statically enable all guest events
Date: Fri, 7 Jul 2017 06:33:37 -0500 [thread overview]
Message-ID: <73eddf81-f124-9668-2920-86e6b4873f63@redhat.com> (raw)
In-Reply-To: <87tw2og0ov.fsf@frigg.lan>
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
On 07/07/2017 02:34 AM, Lluís Vilanova wrote:
> Eric Blake writes:
>
>> On 07/04/2017 03:54 AM, Lluís Vilanova wrote:
>>> The existing optimizations makes it feasible to have them available on all
>>> builds.
>
>> While this change may feel trivial, I think it is a misnomer to include
>> "[trivial]" in the subject line, and I also think it should not go in
>> through qemu-trivial. The ideal trivial patch is one that can be
>> applied in isolation, but your patch can only be applied as part of a
>> series that includes the earlier optimizations that made this one possible.
>
> Ok. Does this mean I should send a new series without the trivial tag?
Probably not worth the effort this time around, unless a maintainer
specifically asks for it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-07-07 11:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 8:30 [Qemu-devel] [PATCH v11 0/6] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches Lluís Vilanova
2017-07-04 8:34 ` [Qemu-devel] [PATCH v11 1/6] trace: Allocate cpu->trace_dstate in place Lluís Vilanova
2017-07-04 8:38 ` [Qemu-devel] [PATCH v11 2/6] trace: [tcg] Delay changes to dynamic state when translating Lluís Vilanova
2017-07-04 8:42 ` [Qemu-devel] [PATCH v11 3/6] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state Lluís Vilanova
2017-07-04 8:46 ` [Qemu-devel] [PATCH v11 4/6] trace: [tcg] Do not generate TCG code to trace dynamically-disabled events Lluís Vilanova
2017-07-04 8:50 ` [Qemu-devel] [PATCH v11 5/6] trace: [tcg, trivial] Re-align generated code Lluís Vilanova
2017-07-04 8:54 ` [Qemu-devel] [PATCH v11 6/6] trace: [trivial] Statically enable all guest events Lluís Vilanova
2017-07-05 21:14 ` Eric Blake
2017-07-07 7:34 ` Lluís Vilanova
2017-07-07 11:33 ` Eric Blake [this message]
2017-07-11 10:48 ` [Qemu-devel] [PATCH v11 0/6] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73eddf81-f124-9668-2920-86e6b4873f63@redhat.com \
--to=eblake@redhat.com \
--cc=cota@braap.org \
--cc=ehabkost@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).