From: Eric Blake <eblake@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, jasowang@redhat.com, sw@weilnetz.de
Subject: Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()
Date: Tue, 5 Dec 2017 08:28:23 -0600 [thread overview]
Message-ID: <73f0bc0d-dd3a-bb81-e56a-c3a38fc1cd71@redhat.com> (raw)
In-Reply-To: <20171205081744.6563-5-mark.cave-ayland@ilande.co.uk>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/net/eepro100.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
>
> - if (carry) {
> - crc = ((crc ^ POLYNOMIAL) | carry);
How does this compile after 1/5 renames POLYNOMIAL to POLYNOMIAL_BE in
net.h?
/me looks
Oh, you have a redundant definition in the .c file, which is now a dead
define. Patch 1 should be updated to remove the duplicate definitions,
and fix code to uniformly use POLYNOMIAL_BE.
But overall, I like what the series is doing.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-12-05 14:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 8:17 [Qemu-devel] [PATCHv2 0/5] net: introduce common net_crc32() and net_crc32_le() functions Mark Cave-Ayland
2017-12-05 8:17 ` [Qemu-devel] [PATCHv2 1/5] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function Mark Cave-Ayland
2017-12-06 3:26 ` Philippe Mathieu-Daudé
2017-12-05 8:17 ` [Qemu-devel] [PATCHv2 2/5] net: introduce net_crc32_le() function Mark Cave-Ayland
2017-12-05 14:31 ` Eric Blake
2017-12-07 5:09 ` Mark Cave-Ayland
2017-12-06 3:27 ` Philippe Mathieu-Daudé
2017-12-05 8:17 ` [Qemu-devel] [PATCHv2 3/5] pcnet: switch lnc_mchash() over to use net_crc32_le() Mark Cave-Ayland
2017-12-05 14:33 ` Eric Blake
2017-12-06 3:28 ` Philippe Mathieu-Daudé
2017-12-05 8:17 ` [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32() Mark Cave-Ayland
2017-12-05 14:28 ` Eric Blake [this message]
2017-12-07 5:08 ` Mark Cave-Ayland
2017-12-05 15:13 ` Stefan Weil
2017-12-05 15:16 ` Stefan Weil
2017-12-07 5:15 ` Mark Cave-Ayland
2017-12-06 3:28 ` Philippe Mathieu-Daudé
2017-12-05 8:17 ` [Qemu-devel] [PATCHv2 5/5] sunhme: switch sunhme_receive() over to use net_crc32_le() Mark Cave-Ayland
2017-12-05 14:34 ` Eric Blake
2017-12-06 3:34 ` Philippe Mathieu-Daudé
2017-12-06 3:40 ` Philippe Mathieu-Daudé
2017-12-07 5:17 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73f0bc0d-dd3a-bb81-e56a-c3a38fc1cd71@redhat.com \
--to=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).