From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E87C43461 for ; Tue, 15 Sep 2020 13:26:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2F3F22248 for ; Tue, 15 Sep 2020 13:26:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h98onnRC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2F3F22248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIAyu-0001iZ-MG for qemu-devel@archiver.kernel.org; Tue, 15 Sep 2020 09:26:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIAgv-0001Ik-JG for qemu-devel@nongnu.org; Tue, 15 Sep 2020 09:08:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46205) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kIAgt-00077P-Mc for qemu-devel@nongnu.org; Tue, 15 Sep 2020 09:08:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600175290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yj7EmIbxSk6p1g7B3itKJgg0gGD43x6CQYeydY1wTqs=; b=h98onnRC+KClflAqjuc7rgfcP32M/TSosOmNdVs09aDY4k+Kcwo9uzXZnLMWIkc32yS1eL ZJKlMnC2ko05zkTY0FXEcEmGFkWegoSBXRCFTgX66tMi34iYy+bZ7YpuD1ExXO0XFQ+cSN 4KaaOXp5yZC+mhrNI7byTUSvuKYxKQs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-121-0NNs0E--O2SpMA6XPilQ8w-1; Tue, 15 Sep 2020 09:08:08 -0400 X-MC-Unique: 0NNs0E--O2SpMA6XPilQ8w-1 Received: by mail-wr1-f69.google.com with SMTP id 33so1224300wre.0 for ; Tue, 15 Sep 2020 06:08:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=QxoKYNqVXwKEEHeHDXrISj2oRcVzI5wxcTA6woAAeJg=; b=PxzaZ0GGpoYvkDirrwLxy6j2eVarBd0OSHus0L8yxQE58PYcoTQ65CoTjDyhyfOQMV LqB4jhWQ092DfyZQdZ0ONuFil7qpm5SThvv5RnYrJ1exf1k9JxMI0uIA+aCbREbFsoxj FJBTzcS8x7dp4CH6ydEJG86U615kHV3kwMdFvjqZj6XFNc9jIjXfOJgqWivcIN+NEisg OORRn+i3H6Dy4fYM40OwvDcH2Pn12pITwecMgu0PJ4xlBV+xJmC7ORyNbGvp5V1qURSs uiMFixG3ApQaJc3QM2J+C4xsOA69qnLLVQHOU9ScXYH34O9ZhyFFspPHZKfN29Dr/7ca 6eUw== X-Gm-Message-State: AOAM532CYhiGjqzjIWtQx9yvcGzsp0U4RtYRPTIWPACe4+kgfbPcOOJR txH4LAPtPGCfvfwN6pUbnv5p8+aetSeyDcKPNPHxWzpV1sm0/szmsCe006wCrnMfBw5UYFXD5CV 2Mfph1AYRPf64q+I= X-Received: by 2002:adf:ef03:: with SMTP id e3mr16811476wro.146.1600175287485; Tue, 15 Sep 2020 06:08:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPTkL/TyOed+90XVzjuISPML4eetFldP4dCg8N7K5/cVHH86fNyKclimw/sWarwH8IptlUBg== X-Received: by 2002:adf:ef03:: with SMTP id e3mr16811458wro.146.1600175287340; Tue, 15 Sep 2020 06:08:07 -0700 (PDT) Received: from [192.168.1.36] (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id u66sm25133567wmg.44.2020.09.15.06.08.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Sep 2020 06:08:06 -0700 (PDT) Subject: Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id() To: Greg Kurz , qemu-devel@nongnu.org References: <20200914123505.612812-1-groug@kaod.org> <20200914123505.612812-11-groug@kaod.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <740605ab-5310-d2fe-eb20-138b8def0b48@redhat.com> Date: Tue, 15 Sep 2020 15:08:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200914123505.612812-11-groug@kaod.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/15 02:10:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , qemu-ppc@nongnu.org, Markus Armbruster , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/14/20 2:35 PM, Greg Kurz wrote: > As recommended in "qapi/error.h", return true on success and false on > failure. This allows to reduce error propagation overhead in the callers. > > Signed-off-by: Greg Kurz > --- > include/hw/ppc/spapr.h | 2 +- > hw/ppc/spapr.c | 5 +++-- > hw/ppc/spapr_cpu_core.c | 5 +---- > 3 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > index c8cd63bc0667..11682f00e8cc 100644 > --- a/include/hw/ppc/spapr.h > +++ b/include/hw/ppc/spapr.h > @@ -909,7 +909,7 @@ void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg); > #define HTAB_SIZE(spapr) (1ULL << ((spapr)->htab_shift)) > > int spapr_get_vcpu_id(PowerPCCPU *cpu); > -void spapr_set_vcpu_id(PowerPCCPU *cpu, int cpu_index, Error **errp); > +bool spapr_set_vcpu_id(PowerPCCPU *cpu, int cpu_index, Error **errp); If you have to respin, please add some doc, at least this would be an improvement: /* Returns: %true on success, %false on error. */ Reviewed-by: Philippe Mathieu-Daudé