qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Idan Horowitz <idan.horowitz@gmail.com>,
	Alexandre Iooss <erdnaxe@crans.org>,
	Mahmoud Mandour <ma.mandourr@gmail.com>
Subject: Re: [RFC PATCH] tests/plugins: add a new vcpu state tracking plugin
Date: Fri, 11 Nov 2022 11:22:43 +0100	[thread overview]
Message-ID: <740d6b2c-a292-8119-173c-8611854ed03d@linaro.org> (raw)
In-Reply-To: <20221108164921.1980508-1-alex.bennee@linaro.org>

On 8/11/22 17:49, Alex Bennée wrote:
> Although we call qemu_plugin_register_vcpu_idle_cb() in the bb test we
> don't really exercise the rest of the state change callbacks. Add a
> new test that tests the whole API.
> 
> [AJB: I wrote this in an attempt to flush out a reproducer for #1195
> although so far now joy.]
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Idan Horowitz <idan.horowitz@gmail.com>
> ---
>   tests/plugin/vcpu.c      | 140 +++++++++++++++++++++++++++++++++++++++
>   tests/plugin/meson.build |   2 +-
>   2 files changed, 141 insertions(+), 1 deletion(-)
>   create mode 100644 tests/plugin/vcpu.c


> +static uint64_t get_timestamp(void) {

Checkpatch complains atbout this bracket ^ position ;)

> +    struct timespec ts;
> +    clock_gettime(CLOCK_MONOTONIC, &ts);
> +    return ts.tv_sec * 1000000000LL + ts.tv_nsec;
> +}



      reply	other threads:[~2022-11-11 10:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 16:49 [RFC PATCH] tests/plugins: add a new vcpu state tracking plugin Alex Bennée
2022-11-11 10:22 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=740d6b2c-a292-8119-173c-8611854ed03d@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=erdnaxe@crans.org \
    --cc=idan.horowitz@gmail.com \
    --cc=ma.mandourr@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).