From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] tests/qtest/qmp-cmd-test: Use inclusive language
Date: Sat, 12 Sep 2020 09:55:16 +0200 [thread overview]
Message-ID: <7413d130-270e-51d6-d56b-8ee928d6c033@redhat.com> (raw)
In-Reply-To: <20200912074922.26103-1-thuth@redhat.com>
On 9/12/20 9:49 AM, Thomas Huth wrote:
> We simply want to ignore certain queries here, so let's rather
> use the term 'ignore' to express this intention.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/qtest/qmp-cmd-test.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/qtest/qmp-cmd-test.c b/tests/qtest/qmp-cmd-test.c
> index 3109a9fe96..18069a82fa 100644
> --- a/tests/qtest/qmp-cmd-test.c
> +++ b/tests/qtest/qmp-cmd-test.c
> @@ -82,9 +82,9 @@ static void test_query(const void *data)
> qtest_quit(qts);
> }
>
> -static bool query_is_blacklisted(const char *cmd)
> +static bool ignore_query(const char *cmd)
> {
> - const char *blacklist[] = {
> + const char *ignorelist[] = {
> /* Not actually queries: */
> "add-fd",
> /* Success depends on target arch: */
> @@ -101,8 +101,8 @@ static bool query_is_blacklisted(const char *cmd)
> };
> int i;
>
> - for (i = 0; blacklist[i]; i++) {
> - if (!strcmp(cmd, blacklist[i])) {
> + for (i = 0; ignorelist[i]; i++) {
> + if (!strcmp(cmd, ignorelist[i])) {
> return true;
> }
> }
> @@ -179,7 +179,7 @@ static void add_query_tests(QmpSchema *schema)
> continue;
> }
>
> - if (query_is_blacklisted(si->name)) {
> + if (ignore_query(si->name)) {
> continue;
> }
>
>
next prev parent reply other threads:[~2020-09-12 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 7:49 [PATCH] tests/qtest/qmp-cmd-test: Use inclusive language Thomas Huth
2020-09-12 7:55 ` Philippe Mathieu-Daudé [this message]
2020-09-12 8:36 ` Paolo Bonzini
2020-09-14 7:20 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7413d130-270e-51d6-d56b-8ee928d6c033@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).