* [PATCH] hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge
@ 2024-09-13 14:48 Thomas Huth
2024-09-13 17:05 ` Philippe Mathieu-Daudé
2024-09-16 19:21 ` Cédric Le Goater
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2024-09-13 14:48 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Michael S. Tsirkin, Marcel Apfelbaum, qemu-s390x
The pci-bridge device is not usable on s390x, so introduce a Kconfig
switch that allows to disable it.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/pci-bridge/Kconfig | 5 +++++
hw/pci-bridge/meson.build | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/pci-bridge/Kconfig b/hw/pci-bridge/Kconfig
index 67077366cc..449ec98643 100644
--- a/hw/pci-bridge/Kconfig
+++ b/hw/pci-bridge/Kconfig
@@ -1,3 +1,8 @@
+config PCI_BRIDGE
+ bool
+ default y if PCI_DEVICES
+ depends on PCI
+
config PCIE_PORT
bool
default y if PCI_DEVICES
diff --git a/hw/pci-bridge/meson.build b/hw/pci-bridge/meson.build
index f2a60434dd..2e0eb0d233 100644
--- a/hw/pci-bridge/meson.build
+++ b/hw/pci-bridge/meson.build
@@ -1,5 +1,5 @@
pci_ss = ss.source_set()
-pci_ss.add(files('pci_bridge_dev.c'))
+pci_ss.add(when: 'CONFIG_PCI_BRIDGE', if_true: files('pci_bridge_dev.c'))
pci_ss.add(when: 'CONFIG_I82801B11', if_true: files('i82801b11.c'))
pci_ss.add(when: 'CONFIG_IOH3420', if_true: files('ioh3420.c'))
pci_ss.add(when: 'CONFIG_PCIE_PORT', if_true: files('pcie_root_port.c', 'gen_pcie_root_port.c'))
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge
2024-09-13 14:48 [PATCH] hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge Thomas Huth
@ 2024-09-13 17:05 ` Philippe Mathieu-Daudé
2024-09-16 19:21 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-09-13 17:05 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: Paolo Bonzini, Michael S. Tsirkin, Marcel Apfelbaum, qemu-s390x
On 13/9/24 16:48, Thomas Huth wrote:
> The pci-bridge device is not usable on s390x, so introduce a Kconfig
> switch that allows to disable it.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/pci-bridge/Kconfig | 5 +++++
> hw/pci-bridge/meson.build | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge
2024-09-13 14:48 [PATCH] hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge Thomas Huth
2024-09-13 17:05 ` Philippe Mathieu-Daudé
@ 2024-09-16 19:21 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2024-09-16 19:21 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: Paolo Bonzini, Michael S. Tsirkin, Marcel Apfelbaum, qemu-s390x
On 9/13/24 16:48, Thomas Huth wrote:
> The pci-bridge device is not usable on s390x, so introduce a Kconfig
> switch that allows to disable it.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
> ---
> hw/pci-bridge/Kconfig | 5 +++++
> hw/pci-bridge/meson.build | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/hw/pci-bridge/Kconfig b/hw/pci-bridge/Kconfig
> index 67077366cc..449ec98643 100644
> --- a/hw/pci-bridge/Kconfig
> +++ b/hw/pci-bridge/Kconfig
> @@ -1,3 +1,8 @@
> +config PCI_BRIDGE
> + bool
> + default y if PCI_DEVICES
> + depends on PCI
> +
> config PCIE_PORT
> bool
> default y if PCI_DEVICES
> diff --git a/hw/pci-bridge/meson.build b/hw/pci-bridge/meson.build
> index f2a60434dd..2e0eb0d233 100644
> --- a/hw/pci-bridge/meson.build
> +++ b/hw/pci-bridge/meson.build
> @@ -1,5 +1,5 @@
> pci_ss = ss.source_set()
> -pci_ss.add(files('pci_bridge_dev.c'))
> +pci_ss.add(when: 'CONFIG_PCI_BRIDGE', if_true: files('pci_bridge_dev.c'))
> pci_ss.add(when: 'CONFIG_I82801B11', if_true: files('i82801b11.c'))
> pci_ss.add(when: 'CONFIG_IOH3420', if_true: files('ioh3420.c'))
> pci_ss.add(when: 'CONFIG_PCIE_PORT', if_true: files('pcie_root_port.c', 'gen_pcie_root_port.c'))
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-16 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-13 14:48 [PATCH] hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge Thomas Huth
2024-09-13 17:05 ` Philippe Mathieu-Daudé
2024-09-16 19:21 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).