qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: armbru@redhat.com, alex.williamson@redhat.com,
	glommer@redhat.com, lcapitulino@redhat.com, jasowang@redhat.com,
	Amit Shah <amit.shah@redhat.com>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCHv3 1/2] net: notify peer about link status change
Date: Wed, 9 Feb 2011 18:45:04 +0200	[thread overview]
Message-ID: <74454724f60ec0a05edf672ec10e303d941f079a.1297269881.git.mst@redhat.com> (raw)
In-Reply-To: <cover.1297269881.git.mst@redhat.com>

qemu makes it possible to disable link at tap
which is not communicated to the guest but
causes all packets to be dropped.

This works for virtio userspace, as qemu
stops giving it packets, but not for
virtio-net connected to vhost-net
as that does not get notified about this change.

Notify peer when this happens, which will then be used
by the follow-up patch to stop/start vhost-net.

Note: it might be a good idea to make peer link status match
tap in this case, so the guest gets an event
and updates the carrier state. For now
stay bug for bug compatible with what we used to have
in userspace.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: pradeep <psuriset@linux.vnet.ibm.com>
---
 net.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/net.c b/net.c
index 9ba5be2..ec4745d 100644
--- a/net.c
+++ b/net.c
@@ -1324,6 +1324,17 @@ done:
     if (vc->info->link_status_changed) {
         vc->info->link_status_changed(vc);
     }
+
+    /* Notify peer. Don't update peer link status: this makes it possible to
+     * disconnect from host network without notifying the guest.
+     * FIXME: is disconnected link status change operation useful?
+     *
+     * Current behaviour is compatible with qemu vlans where there could be
+     * multiple clients that can still communicate with each other in
+     * disconnected mode. For now maintain this compatibility. */
+    if (vc->peer && vc->peer->info->link_status_changed) {
+        vc->peer->info->link_status_changed(vc->peer);
+    }
     return 0;
 }
 
-- 
1.7.3.2.91.g446ac

  reply	other threads:[~2011-02-09 16:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 16:44 [Qemu-devel] [PATCHv3 0/2] vhost: fix tap link down Michael S. Tsirkin
2011-02-09 16:45 ` Michael S. Tsirkin [this message]
2011-02-09 16:45 ` [Qemu-devel] [PATCHv3 2/2] vhost: disable on " Michael S. Tsirkin
2011-02-09 17:09 ` [Qemu-devel] Re: [PATCHv3 0/2] vhost: fix " Alex Williamson
2011-02-10  5:33 ` [Qemu-devel] " Jason Wang
2011-02-20 17:07 ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74454724f60ec0a05edf672ec10e303d941f079a.1297269881.git.mst@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=glommer@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).