From: Thomas Huth <thuth@redhat.com>
To: Collin Walling <walling@linux.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: david@redhat.com, wangyanan55@huawei.com, philmd@linaro.org,
marcel.apfelbaum@gmail.com, eduardo@habkost.net,
armbru@redhat.com
Subject: Re: [PATCH v4 0/2] query-cpu-model-expansion: report deprecated features
Date: Mon, 6 May 2024 14:13:49 +0200 [thread overview]
Message-ID: <744e57f9-5885-4fb2-844f-3f008632d257@redhat.com> (raw)
In-Reply-To: <20240429191059.11806-1-walling@linux.ibm.com>
On 29/04/2024 21.10, Collin Walling wrote:
> Changelog
>
> v4
> - updated cover letter to show example output
> - deprecated features are now a subset of the full CPU model's
> list of features
> - value:
> 1. no longer listing the deprecated features for CPU
> models that never had these features available in the
> first place
> 2. deprecated features will not show up for future CPU
> models that out-right drop these features
> - updated qapi documentation
> - now reflects that these props are a subset of the full
> model's definition of properties
> - added Since: tag to deprecated-props (assuming 9.1)
>
> v3
> - removed optional disable-deprecated-feats argument
> - added deprecated-props array to CpuModelInfo struct
> - amended cover letter language to reflect design
>
> v2
> - removed "static-recommended" expansion type
> - implemented optional disable-deprecated-feats argument
>
> ---
>
> The current implementation of query-cpu-model-expansion is lacking a way to retrieve
> CPU models with properties (i.e. features) that are flagged as deprecated. To remedy
> this, a list of deprecated-props has been appended to the CpuModelInfo struct, and
> will currently be reported by a query-cpu-model-expansion. The features reported in
> the output are a subset of the full CPU model expansion.
>
Thanks, queued for my next pull request now.
Thomas
next prev parent reply other threads:[~2024-05-06 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 19:10 [PATCH v4 0/2] query-cpu-model-expansion: report deprecated features Collin Walling
2024-04-29 19:10 ` [PATCH v4 1/2] target/s390x: report deprecated-props in cpu-model-expansion reply Collin Walling
2024-04-30 5:26 ` Markus Armbruster
2024-04-30 10:13 ` David Hildenbrand
2024-04-29 19:10 ` [PATCH v4 2/2] target/s390x: flag te and cte as deprecated Collin Walling
2024-04-30 10:12 ` David Hildenbrand
2024-04-30 17:17 ` [PATCH v4 0/2] query-cpu-model-expansion: report deprecated features Collin Walling
2024-05-06 12:13 ` Thomas Huth [this message]
2024-05-07 22:35 ` Collin Walling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744e57f9-5885-4fb2-844f-3f008632d257@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=walling@linux.ibm.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).