From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, berrange@redhat.com,
Mark Kanda <mark.kanda@oracle.com>
Subject: Re: [PATCH v2 1/8] qmp: Support for querying stats
Date: Fri, 13 May 2022 16:06:09 +0200 [thread overview]
Message-ID: <7462f89a-264b-866e-dcdb-6df93499b14a@redhat.com> (raw)
In-Reply-To: <87wnepy4qd.fsf@pond.sub.org>
On 5/13/22 14:52, Markus Armbruster wrote:
>> +# @StatsResult:
>> +#
>> +# @provider: provider for this set of statistics.
>> +# @qom-path: QOM path of the object for which the statistics are returned
> Since @qom-path is optional, we better document when it's present. In
> the review thread for v1, you explained "Only if the target is vcpus,
> for the current set of targets." More general, and hopefully still
> correct, would be "Present if that object is a QOM object", but the
> phrasing feels rather clumsy. Would appending ", if any" suffice?
>
Alternatively:
# @qom-path: Path to the object for which the statistics are returned,
# if the object is exposed in the QOM tree
Paolo
next prev parent reply other threads:[~2022-05-13 14:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 8:48 [PATCH v2 0/8] qmp, hmp: statistics subsystem and KVM suport Paolo Bonzini
2022-05-11 8:48 ` [PATCH v2 1/8] qmp: Support for querying stats Paolo Bonzini
2022-05-13 12:52 ` Markus Armbruster
2022-05-13 14:06 ` Paolo Bonzini [this message]
2022-05-13 14:39 ` Markus Armbruster
2022-05-11 8:48 ` [PATCH v2 2/8] kvm: Support for querying fd-based stats Paolo Bonzini
2022-05-11 8:48 ` [PATCH v2 3/8] qmp: add filtering of statistics by target vCPU Paolo Bonzini
2022-05-13 12:53 ` Markus Armbruster
2022-05-11 8:48 ` [PATCH v2 4/8] hmp: add basic "info stats" implementation Paolo Bonzini
2022-05-11 8:48 ` [PATCH v2 5/8] qmp: add filtering of statistics by provider Paolo Bonzini
2022-05-11 8:48 ` [PATCH v2 6/8] hmp: " Paolo Bonzini
2022-05-11 8:48 ` [PATCH v2 7/8] qmp: add filtering of statistics by name Paolo Bonzini
2022-05-11 8:48 ` [PATCH v2 8/8] hmp: " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7462f89a-264b-866e-dcdb-6df93499b14a@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mark.kanda@oracle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).