From: Hanna Czenczek <hreitz@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 2/2] block/blkio: add more comments on the fd passing handling
Date: Wed, 2 Aug 2023 14:02:18 +0200 [thread overview]
Message-ID: <7465bcb8-ec1c-92af-54e6-1f4ccec91f5b@redhat.com> (raw)
In-Reply-To: <20230801160332.122564-3-sgarzare@redhat.com>
On 01.08.23 18:03, Stefano Garzarella wrote:
> As Hanna pointed out, it is not clear in the code why qemu_open()
> can fail, and why blkio_set_int("fd") is not enough to discover
> the `fd` property support.
>
> Let's fix them by adding more details in the code comments.
>
> Suggested-by: Hanna Czenczek <hreitz@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> block/blkio.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
Thanks!
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
prev parent reply other threads:[~2023-08-02 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 16:03 [PATCH 0/2] block/blkio: fix fd leak and add more comments for the fd passing Stefano Garzarella
2023-08-01 16:03 ` [PATCH 1/2] block/blkio: close the fd when blkio_connect() fails Stefano Garzarella
2023-08-02 11:15 ` Hanna Czenczek
2023-08-02 13:58 ` Stefano Garzarella
2023-08-01 16:03 ` [PATCH 2/2] block/blkio: add more comments on the fd passing handling Stefano Garzarella
2023-08-02 12:02 ` Hanna Czenczek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7465bcb8-ec1c-92af-54e6-1f4ccec91f5b@redhat.com \
--to=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).