From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btW04-0002UT-DM for qemu-devel@nongnu.org; Mon, 10 Oct 2016 04:31:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btW00-0001Da-E1 for qemu-devel@nongnu.org; Mon, 10 Oct 2016 04:31:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btW00-0001Cn-7w for qemu-devel@nongnu.org; Mon, 10 Oct 2016 04:31:52 -0400 References: <1474463939-12223-1-git-send-email-pbonzini@redhat.com> <20161010010024-mutt-send-email-mst@kernel.org> From: Paolo Bonzini Message-ID: <746893e0-9947-8047-f5b5-e56ec0f388b5@redhat.com> Date: Mon, 10 Oct 2016 10:31:46 +0200 MIME-Version: 1.0 In-Reply-To: <20161010010024-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, famz@redhat.com On 10/10/2016 00:01, Michael S. Tsirkin wrote: > On Wed, Sep 21, 2016 at 03:18:47PM +0200, Paolo Bonzini wrote: >> This series started as an attempt to always use the dataplane path >> for virtio-blk and virtio-scsi when ioeventfd is active. The aim >> was three-fold: >> >> 1) to add more coverage for dataplane >> >> 2) to remove virtio_add_queue_aio >> >> 3) to simplify the dataplane start/stop code >> >> It achieves the first two objectives, and while it doesn't quite >> achieve the third it does cleanup the generic ioeventfd code in >> virtio-bus more than I expected. In particular, it reduces the set >> of callbacks that transports must implement, and it removes the ugly >> case where ioeventfd is started with generic callbacks and then moved >> to the dataplane callbacks. It also enables some simplification of the >> functions that deal with host notifiers. >> >> I've tested it with virtio-blk, virtio-scsi and vhost-net. >> >> Patches 1 and 2 are simplifications that are too nice to leave >> them for later in the series. >> >> Patch 3 moves some of the ioeventfd code from virtio-bus.c to >> virtio.c. At this point the transition is a bit half-assed, but >> this changes as soon as we remove the generic->dataplane >> handler transition. >> >> Patches 4 to 6 do exactly that, and then the spring cleaning >> begins, lasting for the whole second half of the series. >> >> Opinions, reviews and bug reports? >> >> Thanks, >> >> Paolo > > OK, this looks good to me. Can you pls rebase and repost > so I can merge (there was also a bug report I think)? Sure, I was going to do that today. The bug is just too strict an assertion, I'll fix it on repost. Paolo