Re: [PATCH] tests/functional: Add a ppc sam460ex test

[Thomas Huth <thuth@redhat.com>]

On 03/02/2025 12.29, BALATON Zoltan wrote:
> On Mon, 3 Feb 2025, Cédric Le Goater wrote:
>> The test sequence boots from kernel a sam460ex machine with a
>> virtio-net device to check PCI.
>>
>> The buildroot is built with config :
>>
>>  BR2_powerpc=y
>>  BR2_powerpc_440fp=y
>>
>> and the kernel with the '44x/canyonlands' deconfig and virtio support.
>>
>> Cc: BALATON Zoltan <balaton@eik.bme.hu>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>> MAINTAINERS                           |  1 +
>> tests/functional/meson.build          |  1 +
>> tests/functional/test_ppc_sam460ex.py | 38 +++++++++++++++++++++++++++
>> 3 files changed, 40 insertions(+)
>> create mode 100644 tests/functional/test_ppc_sam460ex.py
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 8d30c5bafd87..e4ab6031511b 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1555,6 +1555,7 @@ F: pc-bios/canyonlands.dt[sb]
>> F: pc-bios/u-boot-sam460ex-20100605.bin
>> F: roms/u-boot-sam460ex
>> F: docs/system/ppc/amigang.rst
>> +F: tests/functional/test_ppc_sam460ex.py
>>
>> pegasos2
>> M: BALATON Zoltan <balaton@eik.bme.hu>
>> diff --git a/tests/functional/meson.build b/tests/functional/meson.build
>> index 868f4a64b60b..6a5f1dc405cb 100644
>> --- a/tests/functional/meson.build
>> +++ b/tests/functional/meson.build
>> @@ -193,6 +193,7 @@ tests_ppc_system_thorough = [
>>   'ppc_40p',
>>   'ppc_amiga',
>>   'ppc_bamboo',
>> +  'ppc_sam460ex',
> 
> Instead of adding a new file this could be within ppc_amiga which was meant 
> to be a place for all AmigaNG boards but only has amigaone for now. Unless 
> there's a good reason for it to be separate due to how tests work that I'm 
> not aware of.

Tests that are in separate files can later be run in parallel, so I think it 
makes sense to keep this in a separate file.

  Thomas