From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>, qemu-devel@nongnu.org
Cc: "Michael Roth" <michael.roth@amd.com>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Greg Kurz" <groug@kaod.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Kyle Evans" <kevans@freebsd.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Warner Losh" <imp@bsdimp.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 09/10] hw/9pfs: use qemu_xxhash4
Date: Fri, 21 Apr 2023 08:51:52 +0200 [thread overview]
Message-ID: <747b7e38-c348-cc4a-daad-93b3b36ae8ec@linaro.org> (raw)
In-Reply-To: <1860032.XFESxothFF@silver>
On 20/4/23 17:35, Christian Schoenebeck wrote:
> On Thursday, April 20, 2023 5:00:08 PM CEST Alex Bennée wrote:
>> No need to pass zeros as we have helpers that do that for us.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> hw/9pfs/9p.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
>> index 9621ec1341..9bf502c45f 100644
>> --- a/hw/9pfs/9p.c
>> +++ b/hw/9pfs/9p.c
>> @@ -741,12 +741,12 @@ static VariLenAffix affixForIndex(uint64_t index)
>> /* creative abuse of tb_hash_func7, which is based on xxhash */
>
> I guess this old comment could be dropped then.
>
> Except of that:
>
> Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-04-21 6:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 14:59 [PATCH 00/10] tracing: remove dynamic vcpu state Alex Bennée
2023-04-20 15:00 ` [PATCH 01/10] *-user: remove the guest_user_syscall tracepoints Alex Bennée
2023-04-20 15:29 ` Warner Losh
2023-04-20 15:00 ` [PATCH 02/10] trace-events: remove the remaining vcpu trace events Alex Bennée
2023-04-21 6:47 ` Philippe Mathieu-Daudé
2023-04-20 15:00 ` [PATCH 03/10] trace: remove vcpu_id from the TraceEvent structure Alex Bennée
2023-04-21 6:50 ` Philippe Mathieu-Daudé
2023-04-20 15:00 ` [PATCH 04/10] scripts/qapi: document the tool that generated the file Alex Bennée
2023-04-20 15:00 ` [PATCH 05/10] qapi: make the vcpu parameters deprecated for 8.1 Alex Bennée
2023-04-20 15:00 ` [PATCH 06/10] trace: remove code that depends on setting vcpu Alex Bennée
2023-04-20 15:00 ` [PATCH 07/10] trace: remove control-vcpu.h Alex Bennée
2023-04-21 6:50 ` Philippe Mathieu-Daudé
2023-04-20 15:00 ` [PATCH 08/10] tcg: remove the final vestiges of dstate Alex Bennée
2023-04-20 15:00 ` [PATCH 09/10] hw/9pfs: use qemu_xxhash4 Alex Bennée
2023-04-20 15:35 ` Christian Schoenebeck
2023-04-21 6:51 ` Philippe Mathieu-Daudé [this message]
2023-04-20 15:00 ` [PATCH 10/10] xxhash: remove qemu_xxhash7 Alex Bennée
2023-04-21 6:53 ` Philippe Mathieu-Daudé
2023-05-01 20:25 ` [PATCH 00/10] tracing: remove dynamic vcpu state Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=747b7e38-c348-cc4a-daad-93b3b36ae8ec@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=groug@kaod.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=stefanha@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).