From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mark Cave-Ayland <mark.caveayland@nutanix.com>,
pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com,
eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 09/14] hw/i386/pc_piix.c: remove pc_system_flash_cleanup_unused() from pc_init_isa()
Date: Thu, 10 Jul 2025 12:28:21 +0200 [thread overview]
Message-ID: <748a2db5-503f-45ea-9507-575e764cf5f5@linaro.org> (raw)
In-Reply-To: <20250704141018.674268-10-mark.caveayland@nutanix.com>
On 4/7/25 16:09, Mark Cave-Ayland wrote:
> This function contains 'assert(PC_MACHINE_GET_CLASS(pcms)->pci_enabled)' and so we can
> safely assume that it should never be used for the isapc machine.
>
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
> hw/i386/pc_piix.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-07-10 10:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 14:09 [PATCH v3 00/14] hw/i386: separate isapc out from pc_piix Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 01/14] hw/i386/pc_piix.c: restrict isapc machine to 32-bit CPUs Mark Cave-Ayland
2025-07-10 10:27 ` Philippe Mathieu-Daudé
2025-07-04 14:09 ` [PATCH v3 02/14] hw/i386/pc_piix.c: duplicate pc_init1() into pc_isa_init() Mark Cave-Ayland
2025-07-10 10:38 ` Philippe Mathieu-Daudé
2025-07-10 15:29 ` Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 03/14] hw/i386/pc_piix.c: remove pcmc->pci_enabled dependent initialisation from pc_init_isa() Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 04/14] hw/i386/pc_piix.c: remove SMI and piix4_pm " Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 05/14] hw/i386/pc_piix.c: remove SGX " Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 06/14] hw/i386/pc_piix.c: remove nvdimm " Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 07/14] hw/i386/pc_piix.c: simplify RAM size logic in pc_init_isa() Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 08/14] hw/i386/pc_piix.c: hardcode hole64_size to 0 " Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 09/14] hw/i386/pc_piix.c: remove pc_system_flash_cleanup_unused() from pc_init_isa() Mark Cave-Ayland
2025-07-10 10:28 ` Philippe Mathieu-Daudé [this message]
2025-07-04 14:09 ` [PATCH v3 10/14] hw/i386/pc_piix.c: always initialise ISA IDE drives in pc_init_isa() Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 11/14] hw/i386/pc_piix.c: assume pcmc->pci_enabled is always false " Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 12/14] hw/i386/pc_piix.c: hardcode pcms->pci_bus to NULL " Mark Cave-Ayland
2025-07-04 14:09 ` [PATCH v3 13/14] hw/i386/pc_piix.c: assume pcmc->pci_enabled is always true in pc_init1() Mark Cave-Ayland
2025-07-10 10:43 ` Philippe Mathieu-Daudé
2025-07-04 14:09 ` [PATCH v3 14/14] hw/i386: move isapc machine to separate isapc.c file Mark Cave-Ayland
2025-07-08 17:36 ` Bernhard Beschow
2025-07-10 8:40 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=748a2db5-503f-45ea-9507-575e764cf5f5@linaro.org \
--to=philmd@linaro.org \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.caveayland@nutanix.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).