[Qemu-devel] [PATCH 0/2] tricore: fixes for CADD and CADDN instructions

[Qemu-devel] [PATCH 0/2] tricore: fixes for CADD and CADDN instructions

[David Brenken]

From: David Brenken <david.brenken@efs-auto.de>

Hello,

this patch series contains a fix for the RCR CADD and RCR CADDN instruction of the TriCore.
The r4 and r3 registers were swapped.

Best regards

David Brenken

David Brenken (2):
  tricore: fixed RCR_CADD instruction
  tricore: fixed RCR_CADDN instruction

 target/tricore/translate.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.7.4

[Qemu-devel] [PATCH 1/2] tricore: fixed RCR_CADD instruction

[David Brenken]

From: David Brenken <david.brenken@efs-auto.de>

Signed-off-by: Christian Richter <christian.richter@efs-auto.de>
Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>

---
 target/tricore/translate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index b5ab40d..0511756 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -5867,8 +5867,8 @@ static void decode_rcr_cond_select(CPUTriCoreState *env, DisasContext *ctx)
 
     switch (op2) {
     case OPC2_32_RCR_CADD:
-        gen_condi_add(TCG_COND_NE, cpu_gpr_d[r1], const9, cpu_gpr_d[r3],
-                      cpu_gpr_d[r4]);
+        gen_condi_add(TCG_COND_NE, cpu_gpr_d[r1], const9, cpu_gpr_d[r4],
+                      cpu_gpr_d[r3]);
         break;
     case OPC2_32_RCR_CADDN:
         gen_condi_add(TCG_COND_EQ, cpu_gpr_d[r1], const9, cpu_gpr_d[r3],
-- 
2.7.4

[Qemu-devel] [PATCH 2/2] tricore: fixed RCR_CADDN instruction

[David Brenken]

From: David Brenken <david.brenken@efs-auto.de>

Signed-off-by: Christian Richter <christian.richter@efs-auto.de>
Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>

---
 target/tricore/translate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 0511756..fce0595 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -5871,8 +5871,8 @@ static void decode_rcr_cond_select(CPUTriCoreState *env, DisasContext *ctx)
                       cpu_gpr_d[r3]);
         break;
     case OPC2_32_RCR_CADDN:
-        gen_condi_add(TCG_COND_EQ, cpu_gpr_d[r1], const9, cpu_gpr_d[r3],
-                      cpu_gpr_d[r4]);
+        gen_condi_add(TCG_COND_EQ, cpu_gpr_d[r1], const9, cpu_gpr_d[r4],
+                      cpu_gpr_d[r3]);
         break;
     case OPC2_32_RCR_SEL:
         temp = tcg_const_i32(0);
-- 
2.7.4

Re: [Qemu-devel] [PATCH 0/2] tricore: fixes for CADD and CADDN instructions

[Bastian Koppelmann]

Hi David,

On 2/7/19 8:39 AM, David Brenken wrote:
> From: David Brenken <david.brenken@efs-auto.de>
>
> Hello,
>
> this patch series contains a fix for the RCR CADD and RCR CADDN instruction of the TriCore.
> The r4 and r3 registers were swapped.
>
> Best regards
>
> David Brenken
>
> David Brenken (2):
>    tricore: fixed RCR_CADD instruction
>    tricore: fixed RCR_CADDN instruction
>
>   target/tricore/translate.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

I queued it for the next PR.

Cheers,

Bastian