From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11EC0C4167D for ; Thu, 9 Nov 2023 13:15:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r14sY-0000GX-Vv; Thu, 09 Nov 2023 08:15:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r14sW-0000Fk-Ro for qemu-devel@nongnu.org; Thu, 09 Nov 2023 08:15:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r14sV-0002wi-Ao for qemu-devel@nongnu.org; Thu, 09 Nov 2023 08:15:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699535722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OWiOSjQbESsRB7XMUMmAhWDOp3hgIQHLa6zJw0k1uiA=; b=VC32kp4kEt3FamuqReLniXSg9zTh64Q3SvSm6J/wIYeRNv7kqRgSEtCufk5oIBaLJuoRlT mxMbIvlFUPIb4utCRAl0/el2/XCH4RE4ZNFR426atDQPdP3FqJK1bmaAEns1OkyfIOAerx eRQnf4RLFn2NDs881yKnW4QsY9DOs3c= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-TgdOLyAiNjWucBC1Ju-qXQ-1; Thu, 09 Nov 2023 08:15:21 -0500 X-MC-Unique: TgdOLyAiNjWucBC1Ju-qXQ-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6707401e1aeso10066476d6.0 for ; Thu, 09 Nov 2023 05:15:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699535720; x=1700140520; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OWiOSjQbESsRB7XMUMmAhWDOp3hgIQHLa6zJw0k1uiA=; b=rB+LZz+ZDMYD6oxOg7RT0KJ7qD1Arj6+sYwwGXs2fG56HGfnEvQvV6u9ZPSVknpPPs NqhK/BFfdavWKqraXZuQ64GVi5WoFWRH0z7LBpFyasSc/G8tyFKbpKBOzkXCdU002Yq6 suQWBa4UzLofN+XK5UCdN8s3/+CRGZ6uwG6eiXIYil0BmwtZZseOrF7Pz5iwBPjHDYOW Y2KHuHftdsPA2uExYOcLEJL/BijHAU3AQNYAhl26EZ5mcci2lDJ+vqxt0TlGocthZUrN 4tG3KRzlwuCzq9NTFIzj1kt0W7UIF+c3atdi1u/JUwpSJiOzYyzZ1dSO3lkZgewS2pgw Fxlg== X-Gm-Message-State: AOJu0YzmGiJCRhqK7emBn2tDG1IWy2G6YoFuZ/1n7/esUNUJ66VNEEFG BybBfO8Ok4w+AoTdFXjphlwsbSHFWA5Dy+HFbDFbHVHdjOw66cJvpanaCa9nqRub1OU6SgPCUL9 mseRBEwtLhZ/05rI= X-Received: by 2002:a05:6214:20a1:b0:66d:10fd:4abb with SMTP id 1-20020a05621420a100b0066d10fd4abbmr4267418qvd.16.1699535720748; Thu, 09 Nov 2023 05:15:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEtURzTkuHhZMPmXkmwPnI0TQuXIm2rzAotA2Xe5lt5vUCMf/LkX/gub2aThrLD/MB7eqleVg== X-Received: by 2002:a05:6214:20a1:b0:66d:10fd:4abb with SMTP id 1-20020a05621420a100b0066d10fd4abbmr4267400qvd.16.1699535720496; Thu, 09 Nov 2023 05:15:20 -0800 (PST) Received: from [192.168.0.6] (ip-109-43-177-79.web.vodafone.de. [109.43.177.79]) by smtp.gmail.com with ESMTPSA id y8-20020a0ceac8000000b0066d32666a27sm2044971qvp.66.2023.11.09.05.15.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 05:15:20 -0800 (PST) Message-ID: <74bb0f66-4383-4627-aedb-859383df1ba8@redhat.com> Date: Thu, 9 Nov 2023 14:15:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] dump: Add arch cleanup function Content-Language: en-US To: Janosch Frank , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, marcandre.lureau@redhat.com, imbrenda@linux.ibm.com References: <20231109120443.185979-1-frankja@linux.ibm.com> <20231109120443.185979-3-frankja@linux.ibm.com> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20231109120443.185979-3-frankja@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 09/11/2023 13.04, Janosch Frank wrote: > Some architectures (s390x) need to cleanup after a failed dump to be > able to continue to run the vm. Add a cleanup function pointer and > call it if it's set. > > Signed-off-by: Janosch Frank > --- > dump/dump.c | 4 ++++ > include/sysemu/dump-arch.h | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/dump/dump.c b/dump/dump.c > index d355ada62e..9eeb7ab453 100644 > --- a/dump/dump.c > +++ b/dump/dump.c > @@ -96,6 +96,10 @@ uint64_t cpu_to_dump64(DumpState *s, uint64_t val) > > static int dump_cleanup(DumpState *s) > { > + if (s->dump_info.arch_cleanup_fn) { > + s->dump_info.arch_cleanup_fn(s); > + } > + > guest_phys_blocks_free(&s->guest_phys_blocks); > memory_mapping_list_free(&s->list); > close(s->fd); > diff --git a/include/sysemu/dump-arch.h b/include/sysemu/dump-arch.h > index 59bbc9be38..743916e46c 100644 > --- a/include/sysemu/dump-arch.h > +++ b/include/sysemu/dump-arch.h > @@ -24,6 +24,7 @@ typedef struct ArchDumpInfo { > void (*arch_sections_add_fn)(DumpState *s); > uint64_t (*arch_sections_write_hdr_fn)(DumpState *s, uint8_t *buff); > int (*arch_sections_write_fn)(DumpState *s, uint8_t *buff); > + void (*arch_cleanup_fn)(DumpState *s); > } ArchDumpInfo; > > struct GuestPhysBlockList; /* memory_mapping.h */ Reviewed-by: Thomas Huth