From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABB86C77B73 for ; Thu, 20 Apr 2023 09:19:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppQRX-0006Q9-Nu; Thu, 20 Apr 2023 05:19:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppQRV-0006PD-Rv for qemu-devel@nongnu.org; Thu, 20 Apr 2023 05:19:05 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppQRT-0006Dn-Sl for qemu-devel@nongnu.org; Thu, 20 Apr 2023 05:19:05 -0400 Received: by mail-wm1-x32b.google.com with SMTP id o9-20020a05600c510900b003f17012276fso2717971wms.4 for ; Thu, 20 Apr 2023 02:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681982342; x=1684574342; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=36y8Q4O8F/j5BGJBVRxBjoQzTY5Un2PWUo5VblEeBto=; b=wIia/i7BRopG0lN7urUbbi+XyLnvfiNZHnnkDK1d20CSImamy9E2RwMSspElv9S9D0 7tvHtsFYjv56iYpC/lByE6qPFgt8YnWbjMJUogUX7POUMn4K4DKeU6UPSgeT8HXjDC8f 8pU29cIkBeMjBhvcgtraeDv9H65hpR62OFPNIbFAiyRSy/fNgYngFVmMLs1//sAXPCYu VqYyMq7gWSgP1yAhusrmMG30HUS4Vsj5MiWQl9amMg6DVUkUOb8lzySLV9oRzkIoJ8eW mjmWq/n9shuKiBueqA1VbQyUs0Vez+bQs/CfGRiH46eUzJQ6M3PI7z7worwb0LBaTd61 9ofg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681982342; x=1684574342; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=36y8Q4O8F/j5BGJBVRxBjoQzTY5Un2PWUo5VblEeBto=; b=jatkTlsWzsDMmJhz1gLEZFwKStZx6q1jWQeufm9rHi1THraWhws+tba+a99P3YHRPO PBnufp+ZjJLFmI6FzsG5yQPBOIwkuqAxi9b9k8ktZ241wc3ftKXtfpZbEYta0ilEc+Iw xuG1EmdIapGKY/tF43iLsykVbSA75OwyfQqcX9QpFBfuk2VqW0Dg69gC2fZ06pUil/yb ooTE0dnWV5E4heV1JW8xBNecDYFralP0hjbuhYMrXu41bxU6Ofvv5e1OzM5eVl5AncXo SUhkBingE7sCsxw+ECK/694hh67XxUyh9fPnn4kD3c4RfJGfGqE2plXU92mDhZ4LCzTs BfBg== X-Gm-Message-State: AAQBX9e8UJfJrbT3gFZtrNWyUHHFuCnxKvxjH8Hv1/NMGgDGyKKn8XRP EZr00VJ3s4B1+evML/kON0JYgw== X-Google-Smtp-Source: AKy350alKRPqeXMQmUsZlj41ZvgLTOQa+3dT/NIx/r4CXwoF2ELIpQ8yPEeGegvEqTVxhqdZ1yakTQ== X-Received: by 2002:a1c:7712:0:b0:3f1:70d5:1be8 with SMTP id t18-20020a1c7712000000b003f170d51be8mr805026wmi.15.1681982341691; Thu, 20 Apr 2023 02:19:01 -0700 (PDT) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id z3-20020adff1c3000000b002fb9e73d5e5sm1418290wro.60.2023.04.20.02.18.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 02:19:01 -0700 (PDT) Message-ID: <74be23e6-015b-cb1d-967e-65fc32347553@linaro.org> Date: Thu, 20 Apr 2023 11:18:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 1/6] tests/requirements.txt: bump up avocado-framework version to 101.0 Content-Language: en-US To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , John Snow Cc: Cleber Rosa , Jan Richter , qemu-devel@nongnu.org, Peter Maydell , Bastian Koppelmann , Markus Armbruster , Beraldo Leal , Thomas Huth , Stefan Hajnoczi , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Radoslaw Biernacki , Leif Lindholm , Paolo Bonzini , Wainer dos Santos Moschetta , qemu-arm@nongnu.org, Kautuk Consul , Hariharan T S References: <20230417134321.3627231-1-alex.bennee@linaro.org> <20230417134321.3627231-2-alex.bennee@linaro.org> <87pm82e74d.fsf@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <87pm82e74d.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.597, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 17/4/23 19:44, Alex Bennée wrote: > > John Snow writes: > >> On Mon, Apr 17, 2023 at 9:43 AM Alex Bennée wrote: >>> >>> From: Kautuk Consul >>> >>> Avocado version 101.0 has a fix to re-compute the checksum >>> of an asset file if the algorithm used in the *-CHECKSUM >>> file isn't the same as the one being passed to it by the >>> avocado user (i.e. the avocado_qemu python module). >>> In the earlier avocado versions this fix wasn't there due >>> to which if the checksum wouldn't match the earlier >>> checksum (calculated by a different algorithm), the avocado >>> code would start downloading a fresh image from the internet >>> URL thus making the test-cases take longer to execute. >>> >>> Bump up the avocado-framework version to 101.0. >>> >>> Signed-off-by: Kautuk Consul >>> Tested-by: Hariharan T S >>> Message-Id: <20230327115030.3418323-2-kconsul@linux.vnet.ibm.com> >>> Message-Id: <20230330101141.30199-10-alex.bennee@linaro.org> >>> >>> --- >>> v2 >>> - limit --max-parallel-tasks $(JOBS_OPTION:-j%=%) >>> --- >>> tests/Makefile.include | 18 +++++++++++------- >>> tests/requirements.txt | 2 +- >>> 2 files changed, 12 insertions(+), 8 deletions(-) >>> >>> diff --git a/tests/Makefile.include b/tests/Makefile.include >>> index 9422ddaece..a4de0ad5a2 100644 >>> --- a/tests/Makefile.include >>> +++ b/tests/Makefile.include >>> @@ -138,14 +138,18 @@ get-vm-image-fedora-31-%: check-venv >>> # download all vm images, according to defined targets >>> get-vm-images: check-venv $(patsubst %,get-vm-image-fedora-31-%, $(FEDORA_31_DOWNLOAD)) >>> >>> +JOBS_OPTION=$(lastword -j1 $(filter-out -j, $(filter -j%,$(MAKEFLAGS)))) >>> + >>> check-avocado: check-venv $(TESTS_RESULTS_DIR) get-vm-images >>> - $(call quiet-command, \ >>> - $(TESTS_PYTHON) -m avocado \ >>> - --show=$(AVOCADO_SHOW) run --job-results-dir=$(TESTS_RESULTS_DIR) \ >>> - $(if $(AVOCADO_TAGS),, --filter-by-tags-include-empty \ >>> - --filter-by-tags-include-empty-key) \ >>> - $(AVOCADO_CMDLINE_TAGS) \ >>> - $(if $(GITLAB_CI),,--failfast) $(AVOCADO_TESTS), \ >>> + $(call quiet-command, \ >>> + $(TESTS_PYTHON) -m avocado \ >>> + --show=$(AVOCADO_SHOW) run --job-results-dir=$(TESTS_RESULTS_DIR) \ >>> + $(if $(AVOCADO_TAGS),, \ >>> + --filter-by-tags-include-empty \ >>> + --filter-by-tags-include-empty-key) \ >>> + --max-parallel-tasks $(JOBS_OPTION:-j%=%) \ >>> + $(AVOCADO_CMDLINE_TAGS) \ >>> + $(if $(GITLAB_CI),,--failfast) $(AVOCADO_TESTS), \ >>> "AVOCADO", "tests/avocado") >>> >>> check-acceptance-deprecated-warning: >>> diff --git a/tests/requirements.txt b/tests/requirements.txt >>> index 0ba561b6bd..a6f73da681 100644 >>> --- a/tests/requirements.txt >>> +++ b/tests/requirements.txt >>> @@ -2,5 +2,5 @@ >>> # in the tests/venv Python virtual environment. For more info, >>> # refer to: https://pip.pypa.io/en/stable/user_guide/#id1 >>> # Note that qemu.git/python/ is always implicitly installed. >>> -avocado-framework==88.1 >>> +avocado-framework==101.0 >>> pycdlib==1.11.0 >>> -- >>> 2.39.2 >>> >> >> I thought there were test failures that prohibited us from bumping the >> Avocado-Framework version. Did those get rectified recently? No, still not working on Darwin. At this point I'm thinking at sending a patch clarifying testing QEMU with Avocado is not supported on Darwin. > I'm not seeing any with your patch applied. Are you using running the Cirrus-CI jobs?