* [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace
@ 2023-01-30 22:20 Helge Deller
2023-01-30 22:24 ` Richard Henderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Helge Deller @ 2023-01-30 22:20 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Helge Deller, qemu-devel
Add output for the missing 4th parameter (size_t sigsetsize).
Signed-off-by: Helge Deller <deller@gmx.de>
---
v2: Use %u instead of %d, as suggested by Laurent Vivier
diff --git a/linux-user/strace.c b/linux-user/strace.c
index 3157e4b420..f0f6ada8cb 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name,
}
qemu_log("%s,", how);
print_pointer(arg1, 0);
- print_pointer(arg2, 1);
+ print_pointer(arg2, 0);
+ print_raw_param("%u", arg3, 1);
print_syscall_epilogue(name);
}
#endif
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace
2023-01-30 22:20 [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace Helge Deller
@ 2023-01-30 22:24 ` Richard Henderson
2023-01-31 11:52 ` Laurent Vivier
2023-01-31 11:57 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2023-01-30 22:24 UTC (permalink / raw)
To: Helge Deller, Laurent Vivier; +Cc: qemu-devel
On 1/30/23 12:20, Helge Deller wrote:
> Add output for the missing 4th parameter (size_t sigsetsize).
>
> Signed-off-by: Helge Deller<deller@gmx.de>
> ---
> v2: Use %u instead of %d, as suggested by Laurent Vivier
>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace
2023-01-30 22:20 [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace Helge Deller
2023-01-30 22:24 ` Richard Henderson
@ 2023-01-31 11:52 ` Laurent Vivier
2023-01-31 11:57 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2023-01-31 11:52 UTC (permalink / raw)
To: Helge Deller; +Cc: qemu-devel
Le 30/01/2023 à 23:20, Helge Deller a écrit :
> Add output for the missing 4th parameter (size_t sigsetsize).
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> v2: Use %u instead of %d, as suggested by Laurent Vivier
>
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 3157e4b420..f0f6ada8cb 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name,
> }
> qemu_log("%s,", how);
> print_pointer(arg1, 0);
> - print_pointer(arg2, 1);
> + print_pointer(arg2, 0);
> + print_raw_param("%u", arg3, 1);
> print_syscall_epilogue(name);
> }
> #endif
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace
2023-01-30 22:20 [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace Helge Deller
2023-01-30 22:24 ` Richard Henderson
2023-01-31 11:52 ` Laurent Vivier
@ 2023-01-31 11:57 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2023-01-31 11:57 UTC (permalink / raw)
To: Helge Deller; +Cc: qemu-devel
Le 30/01/2023 à 23:20, Helge Deller a écrit :
> Add output for the missing 4th parameter (size_t sigsetsize).
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> v2: Use %u instead of %d, as suggested by Laurent Vivier
>
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 3157e4b420..f0f6ada8cb 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name,
> }
> qemu_log("%s,", how);
> print_pointer(arg1, 0);
> - print_pointer(arg2, 1);
> + print_pointer(arg2, 0);
> + print_raw_param("%u", arg3, 1);
> print_syscall_epilogue(name);
> }
> #endif
>
Applied to my linux-user-for-8.0 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-31 11:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-30 22:20 [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace Helge Deller
2023-01-30 22:24 ` Richard Henderson
2023-01-31 11:52 ` Laurent Vivier
2023-01-31 11:57 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).