qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, cohuck@redhat.com, walling@linux.ibm.com,
	pasic@linux.ibm.com, borntraeger@de.ibm.com,
	qemu-s390x@nongnu.org, mhartmay@linux.ibm.com
Subject: Re: [PATCH 2/2] s390x: pv: Fix diag318 PV fencing
Date: Wed, 21 Oct 2020 16:21:32 +0200	[thread overview]
Message-ID: <74c4631b-735c-e5ad-77a3-0bbd9c63c4db@redhat.com> (raw)
In-Reply-To: <ea3dcaba-8d3a-958f-7c6b-f340187f7ba5@linux.ibm.com>


>> Can we move that into s390_get_feat_block instead and check against the
>> feature bit instead?
>>
> You mean fence inside the s390_get_feat_block() function?

Yes, in

s390_fill_feat_block()

and to make it clean even in

s390_has_feat()

based on s390_is_pv().

-- 
Thanks,

David / dhildenb



  reply	other threads:[~2020-10-21 14:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 13:43 [PATCH 0/2] s390x: pv: Diag318 fixes Janosch Frank
2020-10-21 13:43 ` [PATCH 1/2] s390x: pv: Remove sclp boundary checks Janosch Frank
2020-10-21 14:12   ` David Hildenbrand
2020-10-21 15:48   ` Halil Pasic
2020-10-22  8:26   ` Thomas Huth
2020-10-21 13:43 ` [PATCH 2/2] s390x: pv: Fix diag318 PV fencing Janosch Frank
2020-10-21 14:14   ` David Hildenbrand
2020-10-21 14:18     ` Christian Borntraeger
2020-10-21 14:29       ` David Hildenbrand
2020-10-21 14:19     ` Janosch Frank
2020-10-21 14:21       ` David Hildenbrand [this message]
2020-10-22  8:23         ` [PATCH] " Janosch Frank
2020-10-22  8:32           ` David Hildenbrand
2020-10-22  8:39             ` Janosch Frank
2020-10-22  8:47               ` David Hildenbrand
2020-10-22  9:54           ` Halil Pasic
2020-10-22  9:55             ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74c4631b-735c-e5ad-77a3-0bbd9c63c4db@redhat.com \
    --to=david@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=mhartmay@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).