From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMazZ-0007mc-3R for qemu-devel@nongnu.org; Mon, 01 Apr 2013 05:25:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMazX-0006Uh-EL for qemu-devel@nongnu.org; Mon, 01 Apr 2013 05:25:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMazX-0006Ub-6F for qemu-devel@nongnu.org; Mon, 01 Apr 2013 05:25:27 -0400 From: Amit Shah Date: Mon, 1 Apr 2013 14:55:12 +0530 Message-Id: <74d06e1f94cc2337aa1bb6784a7ad2210ec55364.1364808312.git.amit.shah@redhat.com> Subject: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Amit Shah , qemu list Opening backends in non-blocking mode isn't necessary, we don't do anything while waiting for data. This also excuses us from checking for EAGAIN, which for the default random backend, is a very common return error type. Starting the guest with '-device virtio-rng-pci', issuing a 'cat /dev/hwrng' in the guest while also doing 'cat /dev/random' on the host causes backends/rng-random.c:44:entropy_available: assertion failed: (len != -1) without this fix. Reported-by: yunpingzheng Signed-off-by: Amit Shah --- backends/rng-random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/rng-random.c b/backends/rng-random.c index acd20af..252139b 100644 --- a/backends/rng-random.c +++ b/backends/rng-random.c @@ -74,7 +74,7 @@ static void rng_random_opened(RngBackend *b, Error **errp) error_set(errp, QERR_INVALID_PARAMETER_VALUE, "filename", "a valid filename"); } else { - s->fd = qemu_open(s->filename, O_RDONLY | O_NONBLOCK); + s->fd = qemu_open(s->filename, O_RDONLY); if (s->fd == -1) { error_set(errp, QERR_OPEN_FILE_FAILED, s->filename); -- 1.8.1.4