From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v3 6/7] s390x/mmu: DAT table definition overhaul
Date: Fri, 27 Sep 2019 10:59:20 -0700 [thread overview]
Message-ID: <74e9a0ee-bb6a-36e5-a910-75a9f0b23b10@linaro.org> (raw)
In-Reply-To: <20190927095831.23543-7-david@redhat.com>
On 9/27/19 2:58 AM, David Hildenbrand wrote:
> Let's use consitent names for the region/section/page table entries and
> for the macros to extract relevant parts from virtual address. Make them
> match the definitions in the PoP - e.g., how the relevant bits are actually
> called.
>
> Introduce defines for all bits declared in the PoP. This will come in
> handy in follow-up patches.
>
> Add a note where additional information about s390x and the used
> definitions can be found.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/cpu.h | 81 +++++++++++++++++++++++++++++----------
> target/s390x/mem_helper.c | 12 +++---
> target/s390x/mmu_helper.c | 37 ++++++++++--------
> 3 files changed, 87 insertions(+), 43 deletions(-)
Acked-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-09-27 18:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 9:58 [PATCH v3 0/7] s390x/mmu: DAT translation rewrite David Hildenbrand
2019-09-27 9:58 ` [PATCH v3 1/7] s390x/mmu: Drop debug logging from MMU code David Hildenbrand
2019-09-27 9:58 ` [PATCH v3 2/7] s390x/mmu: Move DAT protection handling out of mmu_translate_asce() David Hildenbrand
2019-09-27 9:58 ` [PATCH v3 3/7] s390x/mmu: Inject DAT exceptions from a single place David Hildenbrand
2019-09-27 9:58 ` [PATCH v3 4/7] s390x/mmu: Inject PGM_ADDRESSING on boguous table addresses David Hildenbrand
2019-09-27 17:58 ` Richard Henderson
2019-09-27 9:58 ` [PATCH v3 5/7] s390x/mmu: Use TARGET_PAGE_MASK in mmu_translate_pte() David Hildenbrand
2019-09-27 9:58 ` [PATCH v3 6/7] s390x/mmu: DAT table definition overhaul David Hildenbrand
2019-09-27 17:59 ` Richard Henderson [this message]
2019-10-01 4:54 ` Thomas Huth
2019-10-01 7:29 ` David Hildenbrand
2019-09-27 9:58 ` [PATCH v3 7/7] s390x/mmu: Convert to non-recursive page table walk David Hildenbrand
2019-09-27 18:00 ` Richard Henderson
2019-10-01 8:15 ` Thomas Huth
2019-10-01 8:17 ` David Hildenbrand
2019-10-01 8:23 ` Thomas Huth
2019-10-01 8:24 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74e9a0ee-bb6a-36e5-a910-75a9f0b23b10@linaro.org \
--to=richard.henderson@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).