From: Eric Blake <eblake@redhat.com>
To: Lin Ma <lma@suse.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qmp: set accurate parameter name for error msg of device-list-properties
Date: Tue, 24 Jan 2017 10:57:52 -0600 [thread overview]
Message-ID: <750161d4-df3c-e079-758d-3d16417363dc@redhat.com> (raw)
In-Reply-To: <20170124105332.15992-1-lma@suse.com>
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
On 01/24/2017 04:53 AM, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma@suse.com>
> ---
The commit message is rather sparse; is there an easy formula for
triggering the error message, to give more context about the change?
> qmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qmp.c b/qmp.c
> index 0028f0b..812db6c 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -531,7 +531,7 @@ DevicePropertyInfoList *qmp_device_list_properties(const char *typename,
>
> klass = object_class_dynamic_cast(klass, TYPE_DEVICE);
> if (klass == NULL) {
> - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name", TYPE_DEVICE);
> + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", TYPE_DEVICE);
> return NULL;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-01-24 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 10:53 [Qemu-devel] [PATCH] qmp: set accurate parameter name for error msg of device-list-properties Lin Ma
2017-01-24 16:57 ` Eric Blake [this message]
2017-01-24 17:34 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=750161d4-df3c-e079-758d-3d16417363dc@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lma@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).