From: YuYeon Oh <yuyeon.oh@samsung.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary
Date: Mon, 25 Apr 2011 01:19:33 +0000 (GMT) [thread overview]
Message-ID: <7502723.13211303694372539.JavaMail.weblogic@epv6ml05> (raw)
2011/4/24 Peter Maydell
>Thanks for finding this. I agree the fix is required, but I think I'd
>prefer it if the thumb code for this case handled it in the same way
>the disas_arm_insn() code does:
>
> loaded_base = 0;
> TCGV_UNUSED(loaded_var);
> [...]
> tmp = gen_ld32(addr, IS_USER(s));
> if (i == 15) {
> gen_bx(s, tmp);
> } else if (i == rn) {
> loaded_var = tmp;
> loaded_base = 1;
> } else {
> store_reg(s, i, tmp);
> }
> [...]
> if (loaded_base) {
> store_reg(s, rn, loaded_var);
> }
>
>-- PMM
Thank you for your advice. I am going to send a new patch soon.
next reply other threads:[~2011-04-25 1:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 1:19 YuYeon Oh [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-25 1:23 [Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary YuYeon Oh
2011-04-26 17:17 ` Peter Maydell
2011-04-27 18:18 ` Aurelien Jarno
2011-04-24 14:47 오유연
2011-04-24 15:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7502723.13211303694372539.JavaMail.weblogic@epv6ml05 \
--to=yuyeon.oh@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).