hw/display/xlinx-dp: fixing comment

hw/display/xlinx-dp: fixing comment

[Michael Tokarev]

Hi!

Hopefully this address still works. If not, let's just commit Peter's comment.

Back in 2016, this commit introduced xlinx-dp.c:

commit 58ac482a66de09a7590f705e53fc6a3fb8a055e8
Author: Frederic Konrad <konrad.frederic@yahoo.fr>
Date:   Tue Jun 14 15:59:15 2016 +0100

     introduce xlnx-dp

     This is the implementation of the DisplayPort.
     It has an aux-bus to access dpcd and edid.


This commit has the following comment in it:

+static void xlnx_dp_audio_callback(void *opaque, int avail)
+{
+    /*
+     * Get some data from the DPDMA and compute these datas.
+     * Then wait for QEMU's audio subsystem to call this callback.
+     */

As it is, the commit is difficult to understand and has spelling
error in it (datas).  Is the following interpretation by Peter
Maydell correct?

    /*
     * Get the individual left and right audio streams from
     * the DPDMA, and fill the output buffer with the
     * combined stereo audio data adjusted by the volume
     * controls.
     * QEMU's audio subsystem will call this callback
     * repeatedly; we return it the data from the output
     * buffer until it is emptied, and then we will read
     * data from the DPDMA again.
     */

Thanks,

/mjt

Re: hw/display/xlinx-dp: fixing comment

[Frederic Konrad]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

 Hi,
Yes that comment makes sense thanks.

Best Regards,Fred

    Le samedi 26 août 2023 à 12:20:35 UTC+2, Michael Tokarev <mjt@tls.msk.ru> a écrit :  
 
 Hi!

Hopefully this address still works. If not, let's just commit Peter's comment.

Back in 2016, this commit introduced xlinx-dp.c:

commit 58ac482a66de09a7590f705e53fc6a3fb8a055e8
Author: Frederic Konrad <konrad.frederic@yahoo.fr>
Date:  Tue Jun 14 15:59:15 2016 +0100

    introduce xlnx-dp

    This is the implementation of the DisplayPort.
    It has an aux-bus to access dpcd and edid.


This commit has the following comment in it:

+static void xlnx_dp_audio_callback(void *opaque, int avail)
+{
+    /*
+    * Get some data from the DPDMA and compute these datas.
+    * Then wait for QEMU's audio subsystem to call this callback.
+    */

As it is, the commit is difficult to understand and has spelling
error in it (datas).  Is the following interpretation by Peter
Maydell correct?

    /*
    * Get the individual left and right audio streams from
    * the DPDMA, and fill the output buffer with the
    * combined stereo audio data adjusted by the volume
    * controls.
    * QEMU's audio subsystem will call this callback
    * repeatedly; we return it the data from the output
    * buffer until it is emptied, and then we will read
    * data from the DPDMA again.
    */

Thanks,

/mjt
  

[-- Attachment #2: Type: text/html, Size: 3552 bytes --]