From: Eric Blake <eblake@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
zhaolichang <zhaolichang@huawei.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH RFC 01/10] qemu/: fix some comment spelling errors
Date: Mon, 24 Aug 2020 09:33:28 -0500 [thread overview]
Message-ID: <750785b2-c912-489c-f0f0-ad9f2d5801a2@redhat.com> (raw)
In-Reply-To: <87eeoc0x7i.fsf@linaro.org>
On 8/12/20 9:12 AM, Alex Bennée wrote:
>
> zhaolichang <zhaolichang@huawei.com> writes:
>
>> I found that there are many spelling errors in the comments of qemu,
>> so I used the spellcheck tool to check the spelling errors
>> and finally found some spelling errors in the folder.
>>
>> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
>> ---
> <snip>
>
>> diff --git a/gdbstub.c b/gdbstub.c
>> index f3a318c..bbe66b5 100644
>> --- a/gdbstub.c
>> +++ b/gdbstub.c
>> @@ -698,7 +698,7 @@ static uint32_t gdb_get_cpu_pid(CPUState *cpu)
>> {
>> /* TODO: In user mode, we should use the task state PID */
>> if (cpu->cluster_index == UNASSIGNED_CLUSTER_INDEX) {
>> - /* Return the default process' PID */
>> + /* Return the default process's PID */
>
> Hmm I thought this was correct usage as s's -> s' but apparently that is
> only a given rule for possessive plural nouns (processes' PIDs) -
> although apparently it is possible to have singular nouns in plural
> forms so what do I know :-/
Yes, this is one case where s's is valid. But if it bothers you, you
can always rewrite to:
/* Return the PID of the default process */
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-08-24 14:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 10:14 [PATCH RFC 00/10] fix some comment spelling errors zhaolichang
2020-08-12 10:14 ` [PATCH RFC 01/10] qemu/: " zhaolichang
2020-08-12 14:12 ` Alex Bennée
2020-08-24 14:33 ` Eric Blake [this message]
2020-08-12 10:14 ` [PATCH RFC 02/10] migration/: " zhaolichang
2020-08-24 12:32 ` Peter Maydell
2020-08-12 10:14 ` [PATCH RFC 03/10] docs/: " zhaolichang
2020-08-12 14:13 ` Alex Bennée
2020-08-24 12:35 ` Peter Maydell
2020-08-12 10:14 ` [PATCH RFC 04/10] scripts/: " zhaolichang
2020-08-24 12:30 ` Peter Maydell
2020-08-12 10:14 ` [PATCH RFC 05/10] util/: " zhaolichang
2020-08-12 14:14 ` Alex Bennée
2020-08-12 10:14 ` [PATCH RFC 06/10] linux-user/: " zhaolichang
2020-08-12 14:15 ` Alex Bennée
2020-08-12 10:14 ` [PATCH RFC 07/10] block/: " zhaolichang
2020-08-24 12:28 ` Peter Maydell
2020-08-12 10:14 ` [PATCH RFC 08/10] disas/: " zhaolichang
2020-08-24 12:29 ` Peter Maydell
2020-08-12 10:14 ` [PATCH RFC 09/10] qapi/: " zhaolichang
2020-08-24 12:25 ` Markus Armbruster
2020-08-12 10:15 ` [PATCH RFC 10/10] contrib/: " zhaolichang
2020-08-12 14:16 ` Alex Bennée
2020-08-24 12:22 ` [PATCH RFC 00/10] " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=750785b2-c912-489c-f0f0-ad9f2d5801a2@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhaolichang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).