qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, anthony perard <anthony.perard@citrix.com>,
	pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] test-char: start a /char/serial test
Date: Thu, 8 Jun 2017 09:56:59 -0400 (EDT)	[thread overview]
Message-ID: <751038014.31767180.1496930219401.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <765f4687-52ac-ff9d-ef82-037c319e23ec@redhat.com>

Hi

----- Original Message -----
> On 06/08/2017 06:59 AM, Marc-André Lureau wrote:
> > Quite limited test, to check that the chardev can be created with a
> > path and with the tty alias.
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> > ---
> >  tests/test-char.c | 30 ++++++++++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> > 
> > diff --git a/tests/test-char.c b/tests/test-char.c
> > index dfe856cb85..ecc3fec194 100644
> > --- a/tests/test-char.c
> > +++ b/tests/test-char.c
> > @@ -5,6 +5,7 @@
> >  #include "qemu/config-file.h"
> >  #include "qemu/sockets.h"
> >  #include "chardev/char-fe.h"
> > +#include "chardev/char-serial.h" /* for HAVE_CHARDEV_SERIAL */
> 
> Either the comment or the entire #include is now spurious, given the new
> 1/3.

indeed, removed

> 
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
> 
> 

  reply	other threads:[~2017-06-08 13:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 11:59 [Qemu-devel] [PATCH v2 0/3] char: fix chardev aliases regression Marc-André Lureau
2017-06-08 11:59 ` [Qemu-devel] [PATCH v2 1/3] char: fix alias devices regression Marc-André Lureau
2017-06-08 13:29   ` Eric Blake
2017-06-08 15:01   ` Anthony PERARD
2017-06-08 11:59 ` [Qemu-devel] [PATCH v2 2/3] chardev: don't use alias names in parse_compat() Marc-André Lureau
2017-06-08 11:59 ` [Qemu-devel] [PATCH v2 3/3] test-char: start a /char/serial test Marc-André Lureau
2017-06-08 13:29   ` Eric Blake
2017-06-08 13:56     ` Marc-André Lureau [this message]
2017-06-12 16:04 ` [Qemu-devel] [PATCH v2 0/3] char: fix chardev aliases regression Paolo Bonzini
2017-06-12 19:01   ` Marc-André Lureau
2017-06-13 10:05     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=751038014.31767180.1496930219401.JavaMail.zimbra@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).