From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] build: Use $(CC) for compiling .S files
Date: Mon, 20 Jun 2016 07:52:09 -0700 [thread overview]
Message-ID: <7512f461-7f05-90fc-ae21-01c2d89437cb@twiddle.net> (raw)
In-Reply-To: <CAFEAcA_ORvL5Je25Qrrm5tOSEQxPpj+uaBwOaViPkDtdLw-FZg@mail.gmail.com>
On 06/20/2016 06:43 AM, Peter Maydell wrote:
> On 18 June 2016 at 07:47, Richard Henderson <rth@twiddle.net> wrote:
>> We fail to pass to AS all of the different flags that
>> may be required for a given set of CFLAGS. Rather than
>> figuring out the host-specific mapping, it's better to
>> allow the compiler driver to do that.
>>
>> This fixes e.g. ../configure --cpu=i686, but would also
>> be required for ppc and sparc.
>>
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>
> This is basically reverting commit 3dd46c78525a30e98c68 from
> 2013, which explicitly switched to using separate CPP and
> AS steps "because the C compiler could be unsuitable", by
> which I think it means the failure described here:
> https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00558.html
> where if the compiler is clang it might not be able to
> handle some of the code we use in the optionrom assembly
> even though 'as' can.
>
> Does that no longer apply ?
Ah, well, no.
But that report is for building ROMs, where AS plus all of the options are
easily controllable. Whereas this current problem is where we are linking
assembly (safe-syscall.S) into the qemu executable.
These are two completely different usages, and ought to be treated as such.
r~
prev parent reply other threads:[~2016-06-20 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 6:47 [Qemu-devel] [PATCH] build: Use $(CC) for compiling .S files Richard Henderson
2016-06-20 13:43 ` Peter Maydell
2016-06-20 14:52 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7512f461-7f05-90fc-ae21-01c2d89437cb@twiddle.net \
--to=rth@twiddle.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).