From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Laurent Vivier <laurent@vivier.eu>,
David Hildenbrand <david@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Tulio Magno Quites Machado Filho <tuliom@redhat.com>
Subject: Re: [PATCH 4/4] linux-user: Emulate /proc/cpuinfo on s390x
Date: Fri, 02 Jun 2023 14:23:20 +0200 [thread overview]
Message-ID: <752a33dd22b223656b4827eaf28419e3e8f629e9.camel@linux.ibm.com> (raw)
In-Reply-To: <20230601162541.689621-5-iii@linux.ibm.com>
On Thu, 2023-06-01 at 18:25 +0200, Ilya Leoshkevich wrote:
> Some s390x userspace programs are confused when seeing a foreign
> /proc/cpuinfo [1]. Add the emulation for s390x; follow the respective
> kernel code structure where possible.
>
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=2211472
>
> Reported-by: Tulio Magno Quites Machado Filho <tuliom@redhat.com>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> linux-user/syscall.c | 106
> ++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 105 insertions(+), 1 deletion(-)
> @@ -8364,7 +8467,8 @@ int do_guest_openat(CPUArchState *cpu_env, int
> dirfd, const char *pathname,
> #if HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN
> { "/proc/net/route", open_net_route, is_proc },
> #endif
> -#if defined(TARGET_SPARC) || defined(TARGET_HPPA) ||
> defined(TARGET_RISCV)
> +#if defined(TARGET_SPARC) || defined(TARGET_HPPA) || \
> + defined(TARGET_RISCV) || defined(TARGET_S390X)
> { "/proc/cpuinfo", open_cpuinfo, is_proc },
> #endif
> #if defined(TARGET_M68K)
I'll need to add #if defined(TARGET_S390X) for is_proc, otherwise
the build will fail on s390x hosts. I will include this in v2.
next prev parent reply other threads:[~2023-06-02 12:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:25 [PATCH 0/4] linux-user: Emulate /proc/cpuinfo on s390x Ilya Leoshkevich
2023-06-01 16:25 ` [PATCH 1/4] s390x/tcg: Fix CPU address returned by STIDP Ilya Leoshkevich
2023-06-02 12:03 ` David Hildenbrand
2023-06-01 16:25 ` [PATCH 2/4] linux-user/elfload: Expose get_elf_hwcap() on s390x Ilya Leoshkevich
2023-06-02 12:27 ` David Hildenbrand
2023-06-01 16:25 ` [PATCH 3/4] linux-user/elfload: Introduce elf_hwcap_str() " Ilya Leoshkevich
2023-06-02 12:28 ` David Hildenbrand
2023-06-01 16:25 ` [PATCH 4/4] linux-user: Emulate /proc/cpuinfo " Ilya Leoshkevich
2023-06-02 12:23 ` Ilya Leoshkevich [this message]
2023-06-02 12:34 ` David Hildenbrand
2023-06-02 12:36 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=752a33dd22b223656b4827eaf28419e3e8f629e9.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=david@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=tuliom@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).