From: Laurent Vivier <laurent@vivier.eu>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v4 05/24] q800: move CPU object into Q800MachineState
Date: Wed, 21 Jun 2023 19:06:47 +0200 [thread overview]
Message-ID: <7538c78f-37dc-0b15-8245-dead0ec0bd88@vivier.eu> (raw)
In-Reply-To: <be3b7427-5f76-76af-d47a-d2f233357349@ilande.co.uk>
Le 21/06/2023 à 16:28, Mark Cave-Ayland a écrit :
> On 21/06/2023 12:56, BALATON Zoltan wrote:
>
>> On Wed, 21 Jun 2023, Mark Cave-Ayland wrote:
>>> Also change the instantiation of the CPU to use object_initialize_child()
>>> followed by a separate realisation.
>>
>> Also seems to restrict valid CPU types but not mentioned in commit message. Should this patch be
>> split up?
>
> Hmmm good point. Laurent, would you like me to split this into a separate patch or would updating
> the commit message be sufficient?
I'm going to merge the series. Could you send me the update of the commit message?
Thanks,
Laurent
next prev parent reply other threads:[~2023-06-21 17:07 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:53 [PATCH v4 00/24] q800: add support for booting MacOS Classic - part 1 Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 01/24] q800: fix up minor spacing issues in hw_compat_q800 GlobalProperty array Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 02/24] q800: add missing space after parent object in GLUEState Mark Cave-Ayland
2023-06-21 11:41 ` BALATON Zoltan
2023-06-21 14:24 ` Mark Cave-Ayland
2023-06-21 16:12 ` BALATON Zoltan
2023-06-21 8:53 ` [PATCH v4 03/24] q800: introduce Q800MachineState Mark Cave-Ayland
2023-06-21 11:33 ` BALATON Zoltan
2023-06-21 14:14 ` Mark Cave-Ayland
2023-06-21 16:25 ` BALATON Zoltan
2023-06-21 8:53 ` [PATCH v4 04/24] q800: rename q800_init() to q800_machine_init() Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 05/24] q800: move CPU object into Q800MachineState Mark Cave-Ayland
2023-06-21 11:56 ` BALATON Zoltan
2023-06-21 14:28 ` Mark Cave-Ayland
2023-06-21 17:06 ` Laurent Vivier [this message]
2023-06-21 12:27 ` BALATON Zoltan
2023-06-21 8:53 ` [PATCH v4 06/24] q800: move ROM memory region to Q800MachineState Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 07/24] q800: move GLUE device into separate q800-glue.c file Mark Cave-Ayland
2023-06-21 9:46 ` Philippe Mathieu-Daudé
2023-06-21 14:09 ` Mark Cave-Ayland
2023-06-21 12:00 ` BALATON Zoltan
2023-06-21 14:30 ` Mark Cave-Ayland
2023-06-21 16:27 ` BALATON Zoltan
2023-06-21 16:34 ` BALATON Zoltan
2023-06-21 8:53 ` [PATCH v4 08/24] q800-glue.c: switch TypeInfo registration to use DEFINE_TYPES() macro Mark Cave-Ayland
2023-06-21 9:43 ` Philippe Mathieu-Daudé
2023-06-21 8:53 ` [PATCH v4 09/24] q800: move GLUE device to Q800MachineState Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 10/24] q800: introduce mac-io container memory region Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 11/24] q800: reimplement mac-io region aliasing using IO " Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 12/24] q800: move VIA1 device to Q800MachineState Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 13/24] q800: move VIA2 " Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 14/24] hw/net/dp8393x.c: move TYPE_DP8393X and dp8393xState into dp8393x.h Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 15/24] q800: move dp8393x device to Q800MachineState Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 16/24] q800: move ESCC " Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 17/24] q800: move escc_orgate " Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 18/24] q800: move ESP " Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 19/24] q800: move SWIM " Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 20/24] q800: move mac-nubus-bridge " Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 21/24] q800: don't access Nubus bus directly from the mac-nubus-bridge device Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 22/24] q800: move macfb device to Q800MachineState Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 23/24] mac_via: fix rtc command decoding from PRAM addresses 0x0 to 0xf Mark Cave-Ayland
2023-06-21 8:53 ` [PATCH v4 24/24] mac_via: fix rtc command decoding for the PRAM seconds registers Mark Cave-Ayland
2023-06-21 9:42 ` [PATCH v4 00/24] q800: add support for booting MacOS Classic - part 1 Philippe Mathieu-Daudé
2023-06-21 14:06 ` Mark Cave-Ayland
2023-06-22 10:07 ` Philippe Mathieu-Daudé
2023-06-25 22:18 ` Mark Cave-Ayland
2023-06-22 7:34 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7538c78f-37dc-0b15-8245-dead0ec0bd88@vivier.eu \
--to=laurent@vivier.eu \
--cc=balaton@eik.bme.hu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).