qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Cleber Rosa" <crosa@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, "Fam Zheng" <famz@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Caio Carrara" <ccarrara@redhat.com>,
	"Philippe Mathieu-Daudé" <pmathieu@redhat.com>,
	"Laszlo Ersek" <lersek@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] Travis support for the acceptance tests
Date: Tue, 9 Oct 2018 15:46:53 +0200	[thread overview]
Message-ID: <75560722-a9f5-5ec9-b851-d521960ed8eb@redhat.com> (raw)
In-Reply-To: <20181009041826.19462-4-crosa@redhat.com>

Hi Cleber,

On 09/10/2018 06:18, Cleber Rosa wrote:
> This enables the execution of the acceptance tests on Travis.

Did you test this? =)

> 
> Because the Travis environment is based on Ubuntu Trusty, it requires
> the python3-pip.
> 
> Note: while another supposedely required component on newer versions
> (such as on Bionic) split the Python 3 installation further on the
> python3-venv package.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  .travis.yml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 95be6ec59f..db1a31ea51 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -36,6 +36,7 @@ addons:
>        - liburcu-dev
>        - libusb-1.0-0-dev
>        - libvte-2.90-dev
> +      - python3-pip
>        - sparse
>        - uuid-dev
>        - gcovr
> @@ -117,6 +118,11 @@ matrix:
>      - env: CONFIG="--target-list=x86_64-softmmu"
>        python:
>          - "3.6"
> +    # Acceptance (Functional) tests
> +    - env: CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu"
> +           TEST_CMD="make check-acceptance"
> +      python:
> +        - "3.6"
>      # Using newer GCC with sanitizers
>      - addons:
>          apt:
> 

Using the following patch:

-- >8 --
diff --git a/.travis.yml b/.travis.yml
index 95be6ec59f..87e0c9a13f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -118,4 +118,15 @@ matrix:
       python:
         - "3.6"
+    # Acceptance (Functional) tests
+    - env: CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu"
+           TEST_CMD="make check-acceptance"
+           # sudo rm /usr/local/bin/pip*
+      python:
+        - "3.6"
+      addons:
+        apt:
+          packages:
+            - python3-pip
+            - python3.4-venv
     # Using newer GCC with sanitizers
     - addons:
---

I got some improvements until:

  VENV    /home/travis/build/philmd/qemu/tests/venv
  MKDIR   /home/travis/build/philmd/qemu/tests/results
  PIP     /home/travis/build/philmd/qemu/tests/venv-requirements.txt
Exception:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/pip/basecommand.py", line 122, in
main
    status = self.run(options, args)
  File "/usr/lib/python3/dist-packages/pip/commands/install.py", line
283, in run
    requirement_set.install(install_options, global_options,
root=options.root_path)
  File "/usr/lib/python3/dist-packages/pip/req.py", line 1436, in install
    requirement.install(install_options, global_options, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/pip/req.py", line 672, in install
    self.move_wheel_files(self.source_dir, root=root)
  File "/usr/lib/python3/dist-packages/pip/req.py", line 902, in
move_wheel_files
    pycompile=self.pycompile,
  File "/usr/lib/python3/dist-packages/pip/wheel.py", line 206, in
move_wheel_files
    clobber(source, lib_dir, True)
  File "/usr/lib/python3/dist-packages/pip/wheel.py", line 193, in clobber
    os.makedirs(destsubdir)
  File "/usr/lib/python3.4/os.py", line 237, in makedirs
    mkdir(name, mode)
PermissionError: [Errno 13] Permission denied:
'/usr/local/lib/python3.4/dist-packages/avocado'

See: https://travis-ci.org/philmd/qemu/jobs/439138706

  reply	other threads:[~2018-10-09 13:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09  4:18 [Qemu-devel] [PATCH v2 0/3] Bootstrap Python venv and acceptance/functional tests Cleber Rosa
2018-10-09  4:18 ` [Qemu-devel] [PATCH v2 1/3] Bootstrap Python venv for tests Cleber Rosa
2018-10-09 13:25   ` Philippe Mathieu-Daudé
2018-10-09 16:00     ` Cleber Rosa
2018-10-09 16:13       ` Philippe Mathieu-Daudé
2018-10-09 16:54         ` Cleber Rosa
2018-10-09  4:18 ` [Qemu-devel] [PATCH v2 2/3] Acceptance tests: add make rule for running them Cleber Rosa
2018-10-09 16:18   ` Philippe Mathieu-Daudé
2018-10-09 16:57     ` Cleber Rosa
2018-10-09  4:18 ` [Qemu-devel] [PATCH v2 3/3] Travis support for the acceptance tests Cleber Rosa
2018-10-09 13:46   ` Philippe Mathieu-Daudé [this message]
2018-10-09 14:15     ` Alex Bennée
2018-10-09 14:23       ` Philippe Mathieu-Daudé
2018-10-09 16:48     ` Cleber Rosa
2018-10-09 18:16       ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75560722-a9f5-5ec9-b851-d521960ed8eb@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=ccarrara@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=lersek@redhat.com \
    --cc=pmathieu@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).