Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 22/29] hw/arm: Express dependencies of sabrelite with Kconfig

[Thomas Huth <thuth@redhat.com>]

On 25/04/2019 18.43, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
> 
> On 4/18/19 8:00 PM, Thomas Huth wrote:
>> Add Kconfig dependencies for the Sabrelite / iMX6 machine.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  default-configs/arm-softmmu.mak | 4 +---
>>  hw/arm/Kconfig                  | 7 +++++++
>>  hw/arm/Makefile.objs            | 3 ++-
>>  3 files changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
>> index 76508e3910..ef7dd7156a 100644
>> --- a/default-configs/arm-softmmu.mak
>> +++ b/default-configs/arm-softmmu.mak
>> @@ -33,6 +33,7 @@ CONFIG_NETDUINO2=y
>>  CONFIG_MPS2=y
>>  CONFIG_RASPI=y
>>  CONFIG_DIGIC=y
>> +CONFIG_SABRELITE=y
>>  
>>  CONFIG_VGA=y
>>  CONFIG_SSI_M25P80=y
>> @@ -40,13 +41,10 @@ CONFIG_IMX_FEC=y
>>  
>>  CONFIG_NRF51_SOC=y
>>  
>> -CONFIG_FSL_IMX6=y
>>  CONFIG_FSL_IMX25=y
>>  CONFIG_FSL_IMX7=y
>>  CONFIG_FSL_IMX6UL=y
>>  
>> -CONFIG_IMX_I2C=y
>> -
>>  CONFIG_PCIE_PORT=y
>>  CONFIG_XIO3130=y
>>  CONFIG_IOH3420=y
>> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
>> index 059fb8282c..065c7acf1b 100644
>> --- a/hw/arm/Kconfig
>> +++ b/hw/arm/Kconfig
>> @@ -177,6 +177,10 @@ config REALVIEW
>>      select DS1338 # I2C RTC+NVRAM
>>      select USB_OHCI
>>  
>> +config SABRELITE
>> +    bool
>> +    select FSL_IMX6
> 
> This one crashes:
> 
> $ qemu-system-aarch64 -display none -M sabrelite
> ERROR:/source/qemu/qom/object.c:454:object_initialize_with_type:
> assertion failed: (type != NULL)
> Aborted (core dumped)

Weird, I was pretty sure to have tested all boards individually ... I
must accidentally have skipped this one. Thanks a lot for testing, I'll
fix it in v6.

 Thomas