From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgzyJ-0002AU-He for qemu-devel@nongnu.org; Thu, 23 Feb 2017 15:26:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgzyG-0001ML-EW for qemu-devel@nongnu.org; Thu, 23 Feb 2017 15:26:39 -0500 Sender: Richard Henderson References: <1487879800-12352-1-git-send-email-nikunj@linux.vnet.ibm.com> <1487879800-12352-7-git-send-email-nikunj@linux.vnet.ibm.com> From: Richard Henderson Message-ID: <755c77c5-0930-b5ee-0b3b-1e0608301c8d@twiddle.net> Date: Fri, 24 Feb 2017 07:26:30 +1100 MIME-Version: 1.0 In-Reply-To: <1487879800-12352-7-git-send-email-nikunj@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 06/15] target/ppc: remove xer split-out flags(so, ov, ca) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania , qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Cc: qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com On 02/24/2017 06:56 AM, Nikunj A Dadhania wrote: > Now get rid all the split out variables so, ca, ov. After this patch, > all the bits are stored in CPUPPCState::xer at appropriate places. > > Signed-off-by: Nikunj A Dadhania > --- > target/ppc/cpu.c | 8 +--- > target/ppc/cpu.h | 26 ++++++------ > target/ppc/int_helper.c | 12 +++--- > target/ppc/translate.c | 106 +++++++++++++++++++++++++----------------------- > 4 files changed, 78 insertions(+), 74 deletions(-) I do not think this is a good direction to take this. r~