From: Eric Blake <eblake@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Stefan Weil" <sw@weilnetz.de>,
qemu-devel@nongnu.org
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH-for-5.1?] qapi/error: Check format string argument in error_propagate_prepend()
Date: Thu, 23 Jul 2020 08:19:08 -0500 [thread overview]
Message-ID: <7564d2fc-facb-2b22-46ed-e40ad1d117a0@redhat.com> (raw)
In-Reply-To: <0b9f2a2e-0d54-08eb-60fa-237d29c2529e@redhat.com>
On 7/23/20 5:04 AM, Philippe Mathieu-Daudé wrote:
>>
>> error_vprepend is one more candidate for GCC_FMT_ATTR. Maybe you can add
>> that, too.
>
> This one is different as it uses a va_list. Now I realize it is
> only called in util/error.c, and all its callers are guarded with
> GCC_FMT_ATTR. Maybe we can make it static to simplify... Markus?
Using GCC_FMT_ATTR on va_list functions is just fine; the difference is
that you spell its parameters (n, 0) instead of (n, n + 1). As for
marking the function static, that was just discussed and rejected:
https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg06730.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-07-23 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 9:13 [PATCH-for-5.1?] qapi/error: Check format string argument in error_propagate_prepend() Philippe Mathieu-Daudé
2020-07-23 9:44 ` Stefan Weil
2020-07-23 10:04 ` Philippe Mathieu-Daudé
2020-07-23 13:16 ` Markus Armbruster
2020-07-23 13:19 ` Eric Blake [this message]
2020-07-23 13:09 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7564d2fc-facb-2b22-46ed-e40ad1d117a0@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).