From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7405C433E1 for ; Thu, 23 Jul 2020 13:19:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 845C520737 for ; Thu, 23 Jul 2020 13:19:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cNNX9fjw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 845C520737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyb8c-0006YD-Pq for qemu-devel@archiver.kernel.org; Thu, 23 Jul 2020 09:19:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyb84-000675-Ep for qemu-devel@nongnu.org; Thu, 23 Jul 2020 09:19:20 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:43616 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jyb82-00041n-Ts for qemu-devel@nongnu.org; Thu, 23 Jul 2020 09:19:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595510357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/F6fQqxtL6rjnDSerx2msu1GpQnYZzg4thHgmZ2c2f8=; b=cNNX9fjw4LW4Ho04atnCsH395anpsKXGnkhQ24/pUBsTtVi5tixXIH3hudIC8ffxsLtLGV lbbZr1IfSZ9sVwdH06scpr5XSXolRK8qYHHjjHwmFCW4ryzXhEJINgPwJjk9UyRhyYE7u5 bqDPoBbgkXqMZwsOXjL0qG4KiiGeO7Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-171-faTSinyuOleGX8g3yOIoeA-1; Thu, 23 Jul 2020 09:19:10 -0400 X-MC-Unique: faTSinyuOleGX8g3yOIoeA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3EB757; Thu, 23 Jul 2020 13:19:09 +0000 (UTC) Received: from [10.3.112.189] (ovpn-112-189.phx2.redhat.com [10.3.112.189]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3EF785D9D3; Thu, 23 Jul 2020 13:19:09 +0000 (UTC) Subject: Re: [PATCH-for-5.1?] qapi/error: Check format string argument in error_propagate_prepend() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Stefan Weil , qemu-devel@nongnu.org References: <20200723091309.18690-1-philmd@redhat.com> <0b9f2a2e-0d54-08eb-60fa-237d29c2529e@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <7564d2fc-facb-2b22-46ed-e40ad1d117a0@redhat.com> Date: Thu, 23 Jul 2020 08:19:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0b9f2a2e-0d54-08eb-60fa-237d29c2529e@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 22:13:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/23/20 5:04 AM, Philippe Mathieu-Daudé wrote: >> >> error_vprepend is one more candidate for GCC_FMT_ATTR. Maybe you can add >> that, too. > > This one is different as it uses a va_list. Now I realize it is > only called in util/error.c, and all its callers are guarded with > GCC_FMT_ATTR. Maybe we can make it static to simplify... Markus? Using GCC_FMT_ATTR on va_list functions is just fine; the difference is that you spell its parameters (n, 0) instead of (n, n + 1). As for marking the function static, that was just discussed and rejected: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg06730.html -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org