qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Laurent@vivier.eu
Subject: Re: [PATCH 3/3] linux-user/arm: Implement __kernel_cmpxchg64 with host atomics
Date: Tue, 15 Mar 2022 11:31:58 -0700	[thread overview]
Message-ID: <75a17177-557c-6a47-9724-2a8bb5aa6dbb@linaro.org> (raw)
In-Reply-To: <CAFEAcA_8vJOJBatwFiX255n3HgTBBhCtiquGfJ8U5ryuL+-v0g@mail.gmail.com>

On 3/15/22 11:18, Peter Maydell wrote:
>> -segv:
>> -    end_exclusive();
>> -    /* We get the PC of the entry address - which is as good as anything,
>> -       on a real kernel what you get depends on which mode it uses. */
> 
> This comment about the PC the guest signal handler is going
> to see when we take the SEGV is still valid, I think ?

Yes.  I guess I could move it to the block comment in front of atomic_mmu_lookup, because 
it would apply to both the SEGV and the BUS raised there.


r~


  reply	other threads:[~2022-03-15 18:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14  4:43 [PATCH 0/3] linux-user/arm: Improvements for commpage atomics Richard Henderson
2022-03-14  4:43 ` [PATCH 1/3] linux-user/arm: Implement __kernel_memory_barrier Richard Henderson
2022-03-15 18:11   ` Peter Maydell
2022-03-22 11:46   ` Laurent Vivier
2022-03-14  4:43 ` [PATCH 2/3] linux-user/arm: Implement __kernel_cmpxchg with host atomics Richard Henderson
2022-03-15 18:16   ` Peter Maydell
2022-03-22 11:46   ` Laurent Vivier
2022-03-22 20:08     ` Laurent Vivier
2022-03-23  0:41       ` Richard Henderson
2022-03-14  4:43 ` [PATCH 3/3] linux-user/arm: Implement __kernel_cmpxchg64 " Richard Henderson
2022-03-15 18:18   ` Peter Maydell
2022-03-15 18:31     ` Richard Henderson [this message]
2022-03-22 11:52       ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75a17177-557c-6a47-9724-2a8bb5aa6dbb@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=Laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).