qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 4/8] hw/tpm: Remove unnecessary 'tpm_int.h' header inclusion
Date: Thu, 11 Jun 2020 07:56:06 -0400	[thread overview]
Message-ID: <75a54014-700e-2a32-307c-ac1ea9d01b84@linux.ibm.com> (raw)
In-Reply-To: <20200610200247.21378-5-philmd@redhat.com>

On 6/10/20 4:02 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>


> ---
>   hw/tpm/tpm_crb.c        | 1 -
>   hw/tpm/tpm_spapr.c      | 1 -
>   hw/tpm/tpm_tis_common.c | 1 -
>   3 files changed, 3 deletions(-)
>
> diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c
> index cd004e7f8e..664ff70ef9 100644
> --- a/hw/tpm/tpm_crb.c
> +++ b/hw/tpm/tpm_crb.c
> @@ -25,7 +25,6 @@
>   #include "migration/vmstate.h"
>   #include "sysemu/tpm_backend.h"
>   #include "sysemu/reset.h"
> -#include "tpm_int.h"
>   #include "tpm_util.h"
>   #include "tpm_ppi.h"
>   #include "trace.h"
> diff --git a/hw/tpm/tpm_spapr.c b/hw/tpm/tpm_spapr.c
> index ce65eb2e45..ab1a86ad6e 100644
> --- a/hw/tpm/tpm_spapr.c
> +++ b/hw/tpm/tpm_spapr.c
> @@ -20,7 +20,6 @@
>   #include "migration/vmstate.h"
>   
>   #include "sysemu/tpm_backend.h"
> -#include "tpm_int.h"
>   #include "tpm_util.h"
>   
>   #include "hw/ppc/spapr.h"
> diff --git a/hw/tpm/tpm_tis_common.c b/hw/tpm/tpm_tis_common.c
> index 1af4bce139..94704870f6 100644
> --- a/hw/tpm/tpm_tis_common.c
> +++ b/hw/tpm/tpm_tis_common.c
> @@ -33,7 +33,6 @@
>   #include "hw/qdev-properties.h"
>   #include "migration/vmstate.h"
>   #include "sysemu/tpm_backend.h"
> -#include "tpm_int.h"
>   #include "tpm_util.h"
>   #include "tpm_ppi.h"
>   #include "trace.h"




  reply	other threads:[~2020-06-11 11:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 20:02 [PATCH 0/8] tpm: Split hw/ vs backends/ Philippe Mathieu-Daudé
2020-06-10 20:02 ` [PATCH 1/8] hw/tpm: Do not include 'qemu/osdep.h' in header Philippe Mathieu-Daudé
2020-06-11 11:55   ` Stefan Berger
2020-06-10 20:02 ` [PATCH 2/8] hw/tpm: Include missing 'qemu/option.h' header Philippe Mathieu-Daudé
2020-06-11 11:55   ` Stefan Berger
2020-06-10 20:02 ` [PATCH 3/8] hw/tpm: Move 'hw/acpi/tpm.h' inclusion from header to sources Philippe Mathieu-Daudé
2020-06-11 11:55   ` Stefan Berger
2020-06-10 20:02 ` [PATCH 4/8] hw/tpm: Remove unnecessary 'tpm_int.h' header inclusion Philippe Mathieu-Daudé
2020-06-11 11:56   ` Stefan Berger [this message]
2020-06-10 20:02 ` [PATCH 5/8] hw/tpm: Move few declarations from 'tpm_util.h' to 'tpm_int.h' Philippe Mathieu-Daudé
2020-06-11 11:56   ` Stefan Berger
2020-06-10 20:02 ` [PATCH 6/8] hw/tpm: Move DEFINE_PROP_TPMBE() macro to 'tmp_prop.h' local header Philippe Mathieu-Daudé
2020-06-11 11:57   ` Stefan Berger
2020-06-10 20:02 ` [PATCH 7/8] hw/tpm: Make 'tpm_util.h' publicly accessible as "sysemu/tpm_util.h" Philippe Mathieu-Daudé
2020-06-11 11:57   ` Stefan Berger
2020-06-10 20:02 ` [RFC PATCH 8/8] tpm: Move backend code under the 'backends/' directory Philippe Mathieu-Daudé
2020-06-11 12:00   ` Stefan Berger
2020-06-11 12:05     ` Thomas Huth
2020-06-11 12:21       ` Stefan Berger
2020-06-10 20:09 ` [PATCH 0/8] tpm: Split hw/ vs backends/ Marc-André Lureau
2020-06-10 20:13   ` Philippe Mathieu-Daudé
2020-06-10 20:12 ` Philippe Mathieu-Daudé
2020-06-10 21:26 ` no-reply
2020-06-10 21:31 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75a54014-700e-2a32-307c-ac1ea9d01b84@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).