From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/2] iotests: fix 169
Date: Wed, 11 Apr 2018 18:41:14 +0200 [thread overview]
Message-ID: <75ae7684-99fb-6b8e-2fbf-0e5528c78165@redhat.com> (raw)
In-Reply-To: <20180411122606.367301-3-vsementsov@virtuozzo.com>
On 2018-04-11 14:26, Vladimir Sementsov-Ogievskiy wrote:
> Improve and fix 169:
> - use MIGRATION events instead of RESUME
> - make a TODO: enable dirty-bitmaps capability for offline case
> - recreate vm_b without -incoming near test end
>
> This (likely) fixes racy faults at least of the following types:
>
> - timeout on waiting for RESUME event
> - sha256 mismatch on line 136 (142 after this patch)
> - fail to self.vm_b.launch() on line 135 (141 now after this patch)
>
> And surely fixes cat processes, left after test finish.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> tests/qemu-iotests/169 | 48 +++++++++++++++++++++++++++---------------------
> 1 file changed, 27 insertions(+), 21 deletions(-)
Looks good, makes the test pass reliably (here) and doesn't result in
overly loud meowing due to an abundance of orphaned cats. Thanks!
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2018-04-11 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 12:26 [Qemu-devel] [PATCH v2 0/2] bitmaps persistent and migration fixes Vladimir Sementsov-Ogievskiy
2018-04-11 12:26 ` [Qemu-devel] [PATCH v2 1/2] qcow2: try load bitmaps only once Vladimir Sementsov-Ogievskiy
2018-04-11 13:22 ` Eric Blake
2018-04-11 13:45 ` Vladimir Sementsov-Ogievskiy
2018-04-11 16:33 ` Max Reitz
2018-04-11 12:26 ` [Qemu-devel] [PATCH v2 2/2] iotests: fix 169 Vladimir Sementsov-Ogievskiy
2018-04-11 16:41 ` Max Reitz [this message]
2018-04-11 16:50 ` [Qemu-devel] [PATCH v2 0/2] bitmaps persistent and migration fixes Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75ae7684-99fb-6b8e-2fbf-0e5528c78165@redhat.com \
--to=mreitz@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).