qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>,
	"LEROY Christophe" <christophe.leroy@csgroup.eu>,
	"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
	Greg Kurz <groug@kaod.org>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] hw/ppc/ppc405_boards: Change kernel load address
Date: Fri, 3 Dec 2021 11:31:21 +0100	[thread overview]
Message-ID: <75b27dfe-cb8f-d40c-c1bd-79415264a87f@redhat.com> (raw)
In-Reply-To: <599e5aa0-d7a9-b89c-2da9-5e7c909a6064@kaod.org>

On 03/12/2021 11.27, Cédric Le Goater wrote:
> On 12/2/21 20:32, LEROY Christophe wrote:
>>
>>
>> Le 02/12/2021 à 20:19, Cédric Le Goater a écrit :
>>> On 12/2/21 20:17, Thomas Huth wrote:
>>>> On 02/12/2021 20.14, Cédric Le Goater wrote:
>>>>> The default addresses to load the kernel, fdt, initrd of AMCC boards
>>>>> in U-Boot v2015.10 are :
>>>>>
>>>>>      "kernel_addr_r=1000000\0"
>>>>>      "fdt_addr_r=1800000\0"
>>>>>      "ramdisk_addr_r=1900000\0"
>>>>>
>>>>> The taihu is one of these boards, the ref405ep is not but we don't
>>>>> have much information on it and both boards have a very similar
>>>>> address space layout. Change the kernel load address to match U-Boot
>>>>> expectations and fix loading.
>>>>
>>>> You could additionally mention that U-Boot corrupts the kernel if it
>>>> gets loaded to address 0.
>>>
>>> True. The first word is overwritten with zeros. I looked for it
>>> in the code but could not find the reason.
>>>
>>
>> Isn't it because U-boot unzips the kernel at address 0 ?
> 
> Address 0 is trashed before U-boot loads the kernel.

I guess it's an accidential NULL pointer dereference somewhere in the u-boot 
code ... which will be quite hard to track down when the first page of 
memory is marked as writable... :-/

  Thomas



  reply	other threads:[~2021-12-03 10:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02 19:14 [PATCH] hw/ppc/ppc405_boards: Change kernel load address Cédric Le Goater
2021-12-02 19:17 ` Thomas Huth
2021-12-02 19:19   ` Cédric Le Goater
2021-12-02 19:32     ` LEROY Christophe
2021-12-03 10:27       ` Cédric Le Goater
2021-12-03 10:31         ` Thomas Huth [this message]
2021-12-03 10:40           ` Peter Maydell
2021-12-03 12:25             ` Cédric Le Goater
2021-12-08 13:07               ` Thomas Huth
2021-12-08 13:15                 ` Cédric Le Goater
2021-12-08 13:19                   ` Thomas Huth
2021-12-08 16:54                     ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75b27dfe-cb8f-d40c-c1bd-79415264a87f@redhat.com \
    --to=thuth@redhat.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).